diff options
| author | Jerome Forissier <jerome@forissier.org> | 2020-09-03 14:37:31 +0200 |
|---|---|---|
| committer | Jérôme Forissier <jerome@forissier.org> | 2020-09-04 14:25:44 +0200 |
| commit | 3513f961cda064f90d10f7de72af6330427a2013 (patch) | |
| tree | d034d13b91a2e19cfe1954618e26629426f5721d /core/arch/arm/kernel/tlb_helpers_a32.S | |
| parent | 827be46c173f31c57006af70ca3a15a5b1a7fba3 (diff) | |
arm32: fold UNWIND(.fnstart/.fnend) into the FUNC macros
This change applies to arm32 assembler sources.
Instead of using UNWIND(.fnstart) after FUNC or LOCAL_FUNC and
UNWIND(.fnend) before END_FUNC, let's fold these statements into the
FUNC macros.
The .fnstart/.fnend directives mark the start and end of a function
with an unwind table entry (.ARM.exidx) and therefore a function
without them has no entry and cannot be unwound. This means that a
stack dump (on abort or panic) would stop when reaching such a
function.
As a result of this patch, a small number of functions now have an
entry in the unwind table when they had none before (the functions
which were using FUNC or LOCAL_FUNC but had no .fnstart/.fnend). It was
almost always a bug and this pacth only increases the size of the
.ARM.exidx section by a few bytes (tested on QEMU).
Signed-off-by: Jerome Forissier <jerome@forissier.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Diffstat (limited to 'core/arch/arm/kernel/tlb_helpers_a32.S')
| -rw-r--r-- | core/arch/arm/kernel/tlb_helpers_a32.S | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/core/arch/arm/kernel/tlb_helpers_a32.S b/core/arch/arm/kernel/tlb_helpers_a32.S index ab132610..e65384c9 100644 --- a/core/arch/arm/kernel/tlb_helpers_a32.S +++ b/core/arch/arm/kernel/tlb_helpers_a32.S @@ -9,29 +9,24 @@ /* void tlbi_all(void); */ FUNC tlbi_all , : -UNWIND( .fnstart) dsb ishst /* Sync with table update */ write_tlbiallis /* Invalidate TLBs */ dsb ish /* Sync with tlb invalidation completion */ isb /* Sync execution on tlb update */ bx lr -UNWIND( .fnend) END_FUNC tlbi_all /* void tlbi_mva_allasid(vaddr_t mva); */ FUNC tlbi_mva_allasid , : -UNWIND( .fnstart) dsb ishst /* Sync with table update */ write_tlbimvaais r0 /* Inval TLB by MVA all ASID Inner Sharable */ dsb ish /* Sync with tlb invalidation completion */ isb /* Sync execution on tlb update */ bx lr -UNWIND( .fnend) END_FUNC tlbi_mva_allasid /* void tlbi_asid(unsigned long asid); */ FUNC tlbi_asid , : -UNWIND( .fnstart) dsb ishst /* Sync with table update */ write_tlbiasidis r0 /* Inval unified TLB by ASID Inner Sharable */ orr r0, r0, #1 /* Select the kernel ASID */ @@ -39,5 +34,4 @@ UNWIND( .fnstart) dsb ish /* Sync with tlb invalidation completion */ isb /* Sync execution on tlb update */ bx lr -UNWIND( .fnend) END_FUNC tlbi_asid |