diff options
| author | Andrew Boie <andrew.p.boie@intel.com> | 2016-09-12 09:51:10 -0700 |
|---|---|---|
| committer | Anas Nashif <nashif@linux.intel.com> | 2016-09-12 17:53:22 +0000 |
| commit | 31e3a345e513b9a161767113ba411d33f9a3550e (patch) | |
| tree | 671197fe62a5c78e10a39c2786a1b0fe668d86ed /scripts | |
| parent | 94367659141de1db8cacce8c391e7498ac81c826 (diff) | |
gen_idt: validate IRQ line before vector assignment
On systems with fixed IRQ-to-vector mapping (like Quark D2000),
if multiple drivers tried to use the same IRQ line, gen_idt would
report an IDT vector collision rather than multiple IRQ line collision,
which is much less intuitive.
Move the IRQ line validation to before the vector validation to report
an easier to understand error.
Change-Id: I3930d8df38391e4708db5486e4bd4527d33c4cce
Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/gen_idt/gen_idt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/gen_idt/gen_idt.c b/scripts/gen_idt/gen_idt.c index 11ccf1132..ba6a22914 100644 --- a/scripts/gen_idt/gen_idt.c +++ b/scripts/gen_idt/gen_idt.c @@ -445,9 +445,9 @@ static void validate_irq(void) static void validate_input_file(void) { validate_dpl(); /* exits on error */ + validate_irq(); /* exits on error */ validate_vector_id(); /* exits on error */ validate_priority(); /* exits on error */ - validate_irq(); /* exits on error */ } static void generate_idt(void) |