Some type annotations to make Mypy happier

git-svn-id: https://llvm.org/svn/llvm-project/lnt/trunk@349582 91177308-0d34-0410-b5e6-96231b3b80d8

2 files changed, 9 insertions, 3 deletions

diff --git a/lnt/server/db/rules/rule_update_fixed_regressions.py b/lnt/server/db/rules/rule_update_fixed_regressions.py
index 1743ee9..2e420f8 100644
--- a/lnt/server/db/rules/rule_update_fixed_regressions.py
+++ b/lnt/server/db/rules/rule_update_fixed_regressions.py
@@ -3,6 +3,7 @@ Detcted + fixed -> Ignored
 Staged or Active + fixed -> Verify
 """
 from sqlalchemy.orm.session import Session
+from typing import Dict
 
 from lnt.server.db.regression import RegressionState
 from lnt.server.db.regression import get_cr_for_field_change, get_ris
@@ -11,6 +12,7 @@ from lnt.testing.util.commands import timed
 from lnt.util import logger
 from lnt.server.reporting.analysis import MIN_PERCENTAGE_CHANGE
 
+
 def _fixed_rind(session, ts, rind):
     """Is this regression indicator fixed?"""
     fc = rind.field_change
@@ -33,7 +35,7 @@ def is_fixed(session, ts, regression):
 
 
 def impacts(session, ts, run_id, regression):
-    # type: (Session, TestSuiteDB, int, object) -> bool
+    # type: (Session, TestSuiteDB, int, TestSuiteDB.Regression) -> bool
     """Does this run have a chance of impacting this regression?
 
     This is just to prevent doing a full comparison, so we don't have
@@ -67,7 +69,7 @@ def age_out_oldest_regressions(session, ts, num_to_keep=50):
         .join(ts.FieldChange) \
         .all()
 
-    regression_newest_change = {}
+    regression_newest_change = {}  # type: Dict[int, int]
     for regression_id, order_id in regression_orders:
         current = regression_newest_change.get(regression_id)
         if current is None or current < order_id:
diff --git a/lnt/server/db/rules_manager.py b/lnt/server/db/rules_manager.py
index c9fb5aa..dfee2e7 100644
--- a/lnt/server/db/rules_manager.py
+++ b/lnt/server/db/rules_manager.py
@@ -3,6 +3,9 @@ Define facilities for automatically applying rules to data.
 """
 import os
 import re
+
+from typing import Callable, Dict, List
+
 from lnt.util import logger
 
 
@@ -50,7 +53,8 @@ HOOKS = {
     'post_submission_hook': [],
     'post_regression_create_hook': [],
     'is_useful_change': [],
-}
+}  # type: Dict['str', List[Callable]]
+
 DESCRIPTIONS = {}
 HOOKS_LOADED = False