diff options
author | Philip Reames <listmail@philipreames.com> | 2018-11-12 20:15:34 +0000 |
---|---|---|
committer | Philip Reames <listmail@philipreames.com> | 2018-11-12 20:15:34 +0000 |
commit | b884de47c537756d2f83453c0a2d78d30545df74 (patch) | |
tree | 108f663aec7833584b73bcf19c750ef5c4389628 | |
parent | c9db589887bbf5b08504277c25fbe298f66ff051 (diff) |
[GC] Remove so called PreCall safepoints
Remove another bit of unused configuration potential from GCStrategy. It's not entirely clear what the intention here was, but from the docs, it sounds like this may have been subsumed by patchable call support.
Note: This change is deliberately small to make it clear that while implemented, there's nothing using the option. A following NFC will do most of the simplifications.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@346701 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | include/llvm/CodeGen/GCStrategy.h | 1 | ||||
-rw-r--r-- | lib/CodeGen/GCMetadata.cpp | 2 | ||||
-rw-r--r-- | lib/CodeGen/GCRootLowering.cpp | 9 |
3 files changed, 2 insertions, 10 deletions
diff --git a/include/llvm/CodeGen/GCStrategy.h b/include/llvm/CodeGen/GCStrategy.h index b24a9bad3fd..ab0366bebbc 100644 --- a/include/llvm/CodeGen/GCStrategy.h +++ b/include/llvm/CodeGen/GCStrategy.h @@ -66,7 +66,6 @@ namespace GC { /// most runtimes, PostCall safepoints are appropriate. /// enum PointKind { - PreCall, ///< Instr is a call instruction. PostCall ///< Instr is the return address of a call. }; diff --git a/lib/CodeGen/GCMetadata.cpp b/lib/CodeGen/GCMetadata.cpp index fe3d2965794..4bf5335f9d7 100644 --- a/lib/CodeGen/GCMetadata.cpp +++ b/lib/CodeGen/GCMetadata.cpp @@ -105,8 +105,6 @@ void Printer::getAnalysisUsage(AnalysisUsage &AU) const { static const char *DescKind(GC::PointKind Kind) { switch (Kind) { - case GC::PreCall: - return "pre-call"; case GC::PostCall: return "post-call"; } diff --git a/lib/CodeGen/GCRootLowering.cpp b/lib/CodeGen/GCRootLowering.cpp index 8f9df36d84b..fff76f540f5 100644 --- a/lib/CodeGen/GCRootLowering.cpp +++ b/lib/CodeGen/GCRootLowering.cpp @@ -263,16 +263,11 @@ MCSymbol *GCMachineCodeAnalysis::InsertLabel(MachineBasicBlock &MBB, } void GCMachineCodeAnalysis::VisitCallPoint(MachineBasicBlock::iterator CI) { - // Find the return address (next instruction), too, so as to bracket the call - // instruction. + // Find the return address (next instruction), since that's what will be on + // the stack when the call is suspended and we need to inspect the stack. MachineBasicBlock::iterator RAI = CI; ++RAI; - if (FI->getStrategy().needsSafePoint(GC::PreCall)) { - MCSymbol *Label = InsertLabel(*CI->getParent(), CI, CI->getDebugLoc()); - FI->addSafePoint(GC::PreCall, Label, CI->getDebugLoc()); - } - if (FI->getStrategy().needsSafePoint(GC::PostCall)) { MCSymbol *Label = InsertLabel(*CI->getParent(), RAI, CI->getDebugLoc()); FI->addSafePoint(GC::PostCall, Label, CI->getDebugLoc()); |