diff options
| author | Louis Dionne <ldionne@apple.com> | 2019-10-03 14:24:53 +0000 |
|---|---|---|
| committer | Louis Dionne <ldionne@apple.com> | 2019-10-03 14:24:53 +0000 |
| commit | 2933bf8e793e69d882ad423a6de5af101620763f (patch) | |
| tree | 7c659caab50b19fceb4e67b48cdda44f854e7370 | |
| parent | 6f2865e90816f1d3e6cdd2e38432ff576aa7d9c9 (diff) | |
[libc++abi] Do not export some implementation-detail functions
Summary:
Those functions started being mistakenly exported from the libc++abi
shared library after commit r344152 in 2018. Removing these symbols is
technically an ABI break. However, they are not part of the C++ ABI,
they haven't ever been re-exported from libc++, and they are not
declared in any public header, so it's very unlikely that calls to
these functions exist out there. Also, the functions have reserved
names, so any impacted user would have to have tried really hard
being broken by this removal.
Note that avoiding this kind of problem is exactly why we're now
controlling exported symbols explicitly with a textual list.
Also note that applying the hidden visibility attribute is necessary
because the list of exported symbols is only used on Apple platforms
for the time being.
Reviewers: phosek, mclow.lists, EricWF
Subscribers: christof, jkorous, dexonsmith, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D68357
git-svn-id: https://llvm.org/svn/llvm-project/libcxxabi/trunk@373602 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/itanium-base.exp | 5 | ||||
| -rw-r--r-- | src/cxa_exception.h | 6 |
2 files changed, 3 insertions, 8 deletions
diff --git a/lib/itanium-base.exp b/lib/itanium-base.exp index ff0f812..c08c711 100644 --- a/lib/itanium-base.exp +++ b/lib/itanium-base.exp @@ -366,8 +366,3 @@ __ZSt14set_unexpectedPFvvE __ZSt15get_new_handlerv __ZSt15set_new_handlerPFvvE __ZSt9terminatev - -# Misc -__ZN10__cxxabiv119__getExceptionClassEPK17_Unwind_Exception -__ZN10__cxxabiv119__setExceptionClassEP17_Unwind_Exceptiony -__ZN10__cxxabiv121__isOurExceptionClassEPK17_Unwind_Exception diff --git a/src/cxa_exception.h b/src/cxa_exception.h index d7999e0..c94621d 100644 --- a/src/cxa_exception.h +++ b/src/cxa_exception.h @@ -23,9 +23,9 @@ static const uint64_t kOurExceptionClass = 0x434C4E47432B2B00; // CLNGC static const uint64_t kOurDependentExceptionClass = 0x434C4E47432B2B01; // CLNGC++\1 static const uint64_t get_vendor_and_language = 0xFFFFFFFFFFFFFF00; // mask for CLNGC++ -uint64_t __getExceptionClass (const _Unwind_Exception*); -void __setExceptionClass ( _Unwind_Exception*, uint64_t); -bool __isOurExceptionClass(const _Unwind_Exception*); +_LIBCXXABI_HIDDEN uint64_t __getExceptionClass (const _Unwind_Exception*); +_LIBCXXABI_HIDDEN void __setExceptionClass ( _Unwind_Exception*, uint64_t); +_LIBCXXABI_HIDDEN bool __isOurExceptionClass(const _Unwind_Exception*); struct _LIBCXXABI_HIDDEN __cxa_exception { #if defined(__LP64__) || defined(_LIBCXXABI_ARM_EHABI) |