diff options
| author | Roman Lebedev <lebedev.ri@gmail.com> | 2018-05-08 23:15:58 +0000 |
|---|---|---|
| committer | Roman Lebedev <lebedev.ri@gmail.com> | 2018-05-08 23:15:58 +0000 |
| commit | c1ff11bd7945a36c2e888e38cb41ac6da6bc708c (patch) | |
| tree | adbd7a5cf6ae7f88d7e59c0d0f0a891840ac8649 /unittests/clang-tidy | |
| parent | 6dd3238fba21845ae4bd22c79400e43ae56d5a91 (diff) | |
Partially revert r331456: [clang-tidy] Remove AnalyzeTemporaryDtors option.
That broke every single .clang-tidy config out there
which happened to specify AnalyzeTemporaryDtors option:
YAML:5:24: error: unknown key 'AnalyzeTemporaryDtors'
AnalyzeTemporaryDtors: false
^~~~~
Error parsing <...>/.clang-tidy: Invalid argument
More so, that error isn't actually a error, the
clang-tidy does not exit with $? != 0, it continues
with the default config.
Surely this breakage isn't the intended behavior.
But if it is, feel free to revert this commit.
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@331822 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'unittests/clang-tidy')
| -rw-r--r-- | unittests/clang-tidy/ClangTidyOptionsTest.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/unittests/clang-tidy/ClangTidyOptionsTest.cpp b/unittests/clang-tidy/ClangTidyOptionsTest.cpp index 266ebcd7..f50672ca 100644 --- a/unittests/clang-tidy/ClangTidyOptionsTest.cpp +++ b/unittests/clang-tidy/ClangTidyOptionsTest.cpp @@ -58,6 +58,7 @@ TEST(ParseConfiguration, ValidConfiguration) { llvm::ErrorOr<ClangTidyOptions> Options = parseConfiguration("Checks: \"-*,misc-*\"\n" "HeaderFilterRegex: \".*\"\n" + "AnalyzeTemporaryDtors: true\n" "User: some.user"); EXPECT_TRUE(!!Options); EXPECT_EQ("-*,misc-*", *Options->Checks); @@ -69,6 +70,7 @@ TEST(ParseConfiguration, MergeConfigurations) { llvm::ErrorOr<ClangTidyOptions> Options1 = parseConfiguration(R"( Checks: "check1,check2" HeaderFilterRegex: "filter1" + AnalyzeTemporaryDtors: true User: user1 ExtraArgs: ['arg1', 'arg2'] ExtraArgsBefore: ['arg-before1', 'arg-before2'] @@ -77,6 +79,7 @@ TEST(ParseConfiguration, MergeConfigurations) { llvm::ErrorOr<ClangTidyOptions> Options2 = parseConfiguration(R"( Checks: "check3,check4" HeaderFilterRegex: "filter2" + AnalyzeTemporaryDtors: false User: user2 ExtraArgs: ['arg3', 'arg4'] ExtraArgsBefore: ['arg-before3', 'arg-before4'] |