aboutsummaryrefslogtreecommitdiff
path: root/clang-tidy/utils
diff options
context:
space:
mode:
authorRoman Lebedev <lebedev.ri@gmail.com>2018-10-25 19:44:51 +0000
committerRoman Lebedev <lebedev.ri@gmail.com>2018-10-25 19:44:51 +0000
commit3065f23f1ea2ede750b15a2a8f58a4fab864119b (patch)
tree1db9113601262b4f206957a2f87fcba3e5e9687e /clang-tidy/utils
parent3a48eb2b57cb7ef7a04a8b19077cb41866b08e1f (diff)
[clang-tidy] Revert my readability-uppercase-literal-suffix check.
There are some lurking issues with the handling of the SourceManager. Somehow sometimes we end up extracting completely wrong portions of the source buffer. Reverts r344772, r44760, r344758, r344755. git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@345305 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'clang-tidy/utils')
-rw-r--r--clang-tidy/utils/ASTUtils.cpp26
-rw-r--r--clang-tidy/utils/ASTUtils.h12
2 files changed, 0 insertions, 38 deletions
diff --git a/clang-tidy/utils/ASTUtils.cpp b/clang-tidy/utils/ASTUtils.cpp
index 3c0427fd..5c6b9843 100644
--- a/clang-tidy/utils/ASTUtils.cpp
+++ b/clang-tidy/utils/ASTUtils.cpp
@@ -67,32 +67,6 @@ bool exprHasBitFlagWithSpelling(const Expr *Flags, const SourceManager &SM,
return true;
}
-bool rangeIsEntirelyWithinMacroArgument(SourceRange Range,
- const SourceManager *SM) {
- // Check if the range is entirely contained within a macro argument.
- SourceLocation MacroArgExpansionStartForRangeBegin;
- SourceLocation MacroArgExpansionStartForRangeEnd;
- bool RangeIsEntirelyWithinMacroArgument =
- SM &&
- SM->isMacroArgExpansion(Range.getBegin(),
- &MacroArgExpansionStartForRangeBegin) &&
- SM->isMacroArgExpansion(Range.getEnd(),
- &MacroArgExpansionStartForRangeEnd) &&
- MacroArgExpansionStartForRangeBegin == MacroArgExpansionStartForRangeEnd;
-
- return RangeIsEntirelyWithinMacroArgument;
-}
-
-bool rangeContainsMacroExpansion(SourceRange Range, const SourceManager *SM) {
- return rangeIsEntirelyWithinMacroArgument(Range, SM) ||
- Range.getBegin().isMacroID() || Range.getEnd().isMacroID();
-}
-
-bool rangeCanBeFixed(SourceRange Range, const SourceManager *SM) {
- return utils::rangeIsEntirelyWithinMacroArgument(Range, SM) ||
- !utils::rangeContainsMacroExpansion(Range, SM);
-}
-
} // namespace utils
} // namespace tidy
} // namespace clang
diff --git a/clang-tidy/utils/ASTUtils.h b/clang-tidy/utils/ASTUtils.h
index 4196eeb9..ccff000a 100644
--- a/clang-tidy/utils/ASTUtils.h
+++ b/clang-tidy/utils/ASTUtils.h
@@ -27,18 +27,6 @@ bool IsBinaryOrTernary(const Expr *E);
bool exprHasBitFlagWithSpelling(const Expr *Flags, const SourceManager &SM,
const LangOptions &LangOpts,
StringRef FlagName);
-
-// Check if the range is entirely contained within a macro argument.
-bool rangeIsEntirelyWithinMacroArgument(SourceRange Range,
- const SourceManager *SM);
-
-// Check if the range contains any locations from a macro expansion.
-bool rangeContainsMacroExpansion(SourceRange Range, const SourceManager *SM);
-
-// Can a fix-it be issued for this whole Range?
-// FIXME: false-negative if the entire range is fully expanded from a macro.
-bool rangeCanBeFixed(SourceRange Range, const SourceManager *SM);
-
} // namespace utils
} // namespace tidy
} // namespace clang