diff options
author | Roman Lebedev <lebedev.ri@gmail.com> | 2017-09-11 13:12:31 +0000 |
---|---|---|
committer | Roman Lebedev <lebedev.ri@gmail.com> | 2017-09-11 13:12:31 +0000 |
commit | 65938c9a4f07f0d45050ee1915389e2621e2d5f2 (patch) | |
tree | eeceaa46999e7860723936f2a7c9d9bb063082dc /clang-tidy/readability | |
parent | 7ec7900d463e55fff750909b257a6338e6f0694c (diff) |
[clang-tidy] FunctionSizeCheck: wrap FunctionASTVisitor into anon namespace, NFC
This check is relatively simple, and is often being used
as an example. I'm aware of at least two cases, when
simply copying the FunctionASTVisitor class to a new
check resulted in a rather unobvious segfault. Having it
in anonymous namespace prevents such a problem.
No functionality change, so i opted to avoid phabricator,
especially since clang-tidy reviews are seriously jammed.
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@312912 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'clang-tidy/readability')
-rw-r--r-- | clang-tidy/readability/FunctionSizeCheck.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/clang-tidy/readability/FunctionSizeCheck.cpp b/clang-tidy/readability/FunctionSizeCheck.cpp index ea5f7505..e6410ce2 100644 --- a/clang-tidy/readability/FunctionSizeCheck.cpp +++ b/clang-tidy/readability/FunctionSizeCheck.cpp @@ -16,6 +16,7 @@ using namespace clang::ast_matchers; namespace clang { namespace tidy { namespace readability { +namespace { class FunctionASTVisitor : public RecursiveASTVisitor<FunctionASTVisitor> { using Base = RecursiveASTVisitor<FunctionASTVisitor>; @@ -85,6 +86,8 @@ public: unsigned CurrentNestingLevel = 0; }; +} // namespace + FunctionSizeCheck::FunctionSizeCheck(StringRef Name, ClangTidyContext *Context) : ClangTidyCheck(Name, Context), LineThreshold(Options.get("LineThreshold", -1U)), |