diff options
| author | Malcolm Parsons <malcolm.parsons@gmail.com> | 2016-12-17 20:23:14 +0000 |
|---|---|---|
| committer | Malcolm Parsons <malcolm.parsons@gmail.com> | 2016-12-17 20:23:14 +0000 |
| commit | c0907030041f3b78e521c94fbff781af945abd58 (patch) | |
| tree | 37c6713737a1098cf65a13b8f165ba1f517afd65 /clang-tidy/performance | |
| parent | a080ed599c8ac6f61147a0300a25204d8c07bb9b (diff) | |
[clang-tidy] Remove duplicated check from move-constructor-init
Summary:
An addition to the move-constructor-init check was duplicating the
modernize-pass-by-value check.
Remove the additional check and UseCERTSemantics option.
Run the move-constructor-init test with both checks enabled.
Fix modernize-pass-by-value false-positive when initializing a base
class.
Add option to modernize-pass-by-value to only warn about parameters
that are already values.
Reviewers: alexfh, flx, aaron.ballman
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D26453
git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@290051 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'clang-tidy/performance')
| -rw-r--r-- | clang-tidy/performance/UnnecessaryValueParamCheck.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang-tidy/performance/UnnecessaryValueParamCheck.cpp b/clang-tidy/performance/UnnecessaryValueParamCheck.cpp index 0b583843..edc3cf20 100644 --- a/clang-tidy/performance/UnnecessaryValueParamCheck.cpp +++ b/clang-tidy/performance/UnnecessaryValueParamCheck.cpp @@ -95,7 +95,7 @@ void UnnecessaryValueParamCheck::check(const MatchFinder::MatchResult &Result) { // Do not trigger on non-const value parameters when: // 1. they are in a constructor definition since they can likely trigger - // misc-move-constructor-init which will suggest to move the argument. + // modernize-pass-by-value which will suggest to move the argument. if (!IsConstQualified && (llvm::isa<CXXConstructorDecl>(Function) || !Function->doesThisDeclarationHaveABody())) return; |