aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Alfonsi <laurent.alfonsi@linaro.org>2024-05-06 11:20:08 +0200
committerLaurent Alfonsi <laurent.alfonsi@linaro.org>2024-05-06 11:20:42 +0200
commitffff3aa976a62c7dd46b61efaa803a440ed0d341 (patch)
tree62e1968b1a5a50af114eb39ec1131dd1afed6807
parent03a31e648d72a8621f53115869fdfeab9c7010a8 (diff)
Revert "gather-metrics.sh: Failing if no successful benchmark (perf.csv is empty)"HEADmaster
I initially proposed this commit in the following case : if none of the benchmark is successful, we could consider it as a failure. This case was finally considered as a EXTERNAL_FAILURE - probably an infrastructure problem - no need to bisect. This sounded reasonnable, however, if the tcwg_bmk-build.sh is launched on a single benchmark only, which is the case during the bisection, when the single asked benchmark is failing, it ends with a EXTERNAL_FAILURE. Which is a problem for bisection. This is why I am now reverting this commit. This reverts commit 5a30cd3d010c25c351ae551d64420f80f5bdd1b1. Change-Id: I50d30de74e9040da9fdd979e7ff25f0e00788a81
-rwxr-xr-xgather-metrics.sh5
1 files changed, 0 insertions, 5 deletions
diff --git a/gather-metrics.sh b/gather-metrics.sh
index c028b75..28de965 100755
--- a/gather-metrics.sh
+++ b/gather-metrics.sh
@@ -54,11 +54,6 @@ function gather_perf_data ()
$bmk_scripts/fixup-perf-csv.py "$csv_results_dir/perf-tmp.csv" > "$csv_results_dir/perf.csv"
# rm "$csv_results_dir/perf-tmp.csv"
-
- if [ "$(cat $csv_results_dir/perf.csv | wc -l)" == "1" ]; then
- echo "ERROR: perf.csv is empty, no successful benchmark. Aborting."
- exit 1
- fi
}
function check_option()