diff options
| author | Cyril Hrubis <chrubis@suse.cz> | 2014-06-10 13:49:05 +0200 |
|---|---|---|
| committer | Cyril Hrubis <chrubis@suse.cz> | 2014-06-10 14:15:22 +0200 |
| commit | 1dbf0b4a70c0ef7c849a0b3cd42da2c3874f9432 (patch) | |
| tree | 2459d246cda4839136c2c24a6868c3f7bc0587ee /lib/tst_sig.c | |
| parent | 3492b03c1e86370d719328aa4abefac14fd27c6f (diff) | |
lib: Remove -c option and STD_COPIES
Remove -c option that was never working correctly.
The -c option, if set, forks the test in test setup() creating several
instances of the test to be running at the same time. The problems with
the implementation were:
* The failure of the forked tests WAS NOT popagaged to the first
instance
* The test driver (ltp-pan) tracks only the first instance and kills the
rest of the tests instances once the first one finishes
* Most of the tests does not expect to be running concurently
(there are races in using the same test directory, loop devices, etc.)
While the first two would be easy to fix the last one would require
reviewing and testing all testcases which is too much work.
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
Diffstat (limited to 'lib/tst_sig.c')
| -rw-r--r-- | lib/tst_sig.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/lib/tst_sig.c b/lib/tst_sig.c index e57b0530b..5841a34de 100644 --- a/lib/tst_sig.c +++ b/lib/tst_sig.c @@ -77,12 +77,6 @@ static void (*T_cleanup) (); -/**************************************************************************** - * STD_COPIES is defined in parse_opts.c but is externed here in order to - * test whether SIGCHILD should be ignored or not. - ***************************************************************************/ -extern int STD_COPIES; - static void def_handler(); /* default signal handler */ static void (*tst_setup_signal(int, void (*)(int))) (int); @@ -210,11 +204,6 @@ void tst_sig(int fork_flag, void (*handler) (), void (*cleanup) ()) case _SIGGFAULT: #endif break; - - case SIGCLD: - if (fork_flag == FORK || STD_COPIES > 1) - continue; - default: if (tst_setup_signal(sig, handler) == SIG_ERR) tst_resm(TWARN | TERRNO, |