diff options
| author | Chad Versace <chad.versace@linux.intel.com> | 2013-01-28 17:01:54 -0800 |
|---|---|---|
| committer | Chad Versace <chad.versace@linux.intel.com> | 2013-01-29 10:48:18 -0800 |
| commit | 809f0ac1781eedba833d7e9bd6bae256f51221e7 (patch) | |
| tree | 17a71c6c131139695af44cb59049c1cff3708e93 /tests/egl | |
| parent | 637a8e27850ee6c6bd00fed805687149230911d1 (diff) | |
egl_khr_create_context: Explain why context creation must succeed
In test egl_khr_create_context/default-minor-version-gl, context creation
is not required to succeed. When it fails, the test skips.
However, for tests default-{major,minor}-version-gles, context creation
*is* required to succeed. This patch adds comments explaining why,
Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
Diffstat (limited to 'tests/egl')
| -rw-r--r-- | tests/egl/spec/egl_khr_create_context/default-major-version-gles.c | 3 | ||||
| -rw-r--r-- | tests/egl/spec/egl_khr_create_context/default-minor-version-gles.c | 4 |
2 files changed, 7 insertions, 0 deletions
diff --git a/tests/egl/spec/egl_khr_create_context/default-major-version-gles.c b/tests/egl/spec/egl_khr_create_context/default-major-version-gles.c index cf61e019..e7da8457 100644 --- a/tests/egl/spec/egl_khr_create_context/default-major-version-gles.c +++ b/tests/egl/spec/egl_khr_create_context/default-major-version-gles.c @@ -45,6 +45,9 @@ int main(int argc, char **argv) * Request an OpenGL ES 1.x context by explicitly setting the minor * version to 0 and leaving the major version at the default value of * 1. + * + * The EGL_OPENGL_ES_BIT is set in EGLConfig's EGL_RENDERABLE_TYPE, + * so the driver is required to succeed in creating an ES1 context. */ ctx = eglCreateContext(egl_dpy, cfg, EGL_NO_CONTEXT, attribs); if (ctx == EGL_NO_CONTEXT) { diff --git a/tests/egl/spec/egl_khr_create_context/default-minor-version-gles.c b/tests/egl/spec/egl_khr_create_context/default-minor-version-gles.c index 23318325..5fbb8d44 100644 --- a/tests/egl/spec/egl_khr_create_context/default-minor-version-gles.c +++ b/tests/egl/spec/egl_khr_create_context/default-minor-version-gles.c @@ -49,6 +49,10 @@ int main(int argc, char **argv) * Request an OpenGL ES 1.x or 2.0 context by explicitly setting the * major version and leaving the minor version at the default value of * 0. + * + * The EGLConfig's EGL_RENDERABLE_TYPE and the attribute list's + * EGL_CONTEXT_MAJOR_VERSION_KHR have been chosen so that the driver + * is required to succeed at context creation. */ ctx = eglCreateContext(egl_dpy, cfg, EGL_NO_CONTEXT, attribs); if (ctx == EGL_NO_CONTEXT) { |