aboutsummaryrefslogtreecommitdiff
path: root/gdb/ser-tcp.c
diff options
context:
space:
mode:
authorPedro Alves <palves@redhat.com>2013-03-26 20:29:47 +0000
committerPedro Alves <palves@redhat.com>2013-03-26 20:29:47 +0000
commit2c619be216c9fb729c2696fa10957732290b041a (patch)
tree2a32eabaa3134e38ff8499bca0fdb3f1c3c8f6cf /gdb/ser-tcp.c
parent1b493192488ccb9886ffe709864e5f5c0588b004 (diff)
ser-tcp.c: Small signed->unsigned cleanup.
The "set tcp connect-timeout" variable is unsigned: /* Timeout period for connections, in seconds. */ static unsigned int tcp_retry_limit = 15; And used like: /* Check for timeout. */ if (*polls > tcp_retry_limit * POLL_INTERVAL) { errno = ETIMEDOUT; return -1; } Which made me stop and look over why is it that 'polls' is signed. What I found is there's really no reason. gdb/ 2013-03-26 Pedro Alves <palves@redhat.com> * ser-tcp.c (wait_for_connect): Make 'polls' parameter unsigned. (net_open): Make 'polls' local unsigned.
Diffstat (limited to 'gdb/ser-tcp.c')
-rw-r--r--gdb/ser-tcp.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/ser-tcp.c b/gdb/ser-tcp.c
index 34c6af1f31..a818c657ca 100644
--- a/gdb/ser-tcp.c
+++ b/gdb/ser-tcp.c
@@ -83,7 +83,7 @@ static unsigned int tcp_retry_limit = 15;
Returns -1 on timeout or interrupt, otherwise the value of select. */
static int
-wait_for_connect (struct serial *scb, int *polls)
+wait_for_connect (struct serial *scb, unsigned int *polls)
{
struct timeval t;
int n;
@@ -165,7 +165,7 @@ net_open (struct serial *scb, const char *name)
#else
int ioarg;
#endif
- int polls = 0;
+ unsigned int polls = 0;
use_udp = 0;
if (strncmp (name, "udp:", 4) == 0)