diff options
| author | Ulrich Weigand <ulrich.weigand@de.ibm.com> | 2014-11-10 15:11:44 +0100 |
|---|---|---|
| committer | Ulrich Weigand <ulrich.weigand@de.ibm.com> | 2014-11-10 15:11:44 +0100 |
| commit | b1f28d992c916eab861df3fa62d436755f874b62 (patch) | |
| tree | e11a5f334c35e78dc3e6fdce7800dde11194e49e /gdb/eval.c | |
| parent | aceb5ff54262c4b03a11b95656e9080cfd23a9ef (diff) | |
Work around GCC bug 63748
A recent change to eval.c triggered a GCC bug that causes a false positive
"may be used uninitialized" warning in evaluate_subexp_standard. This seems
to be triggered by a specific CFG constructed via setjmp and gotos.
While the GCC bug is in the process of being fixed, there are released
compiler versions (in particular GCC 4.9) in the field that show this
problem. In order to allow compiling GDB with one of those compilers,
this commit slightly reworks the CFG (in an equivalent way) of the
affected function, so that the GCC bug is no longer triggered.
gdb/ChangeLog:
* eval.c (evaluate_subexp_standard): Work around GCC bug 63748.
Diffstat (limited to 'gdb/eval.c')
| -rw-r--r-- | gdb/eval.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/eval.c b/gdb/eval.c index c49f7b63eb..655ea223b1 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -1696,8 +1696,6 @@ evaluate_subexp_standard (struct type *expect_type, do_call_it: - if (noside == EVAL_SKIP) - goto nosideret; if (argvec[0] == NULL) error (_("Cannot evaluate function -- may be inlined")); if (noside == EVAL_AVOID_SIDE_EFFECTS) @@ -1804,6 +1802,8 @@ evaluate_subexp_standard (struct type *expect_type, for (; tem <= nargs; tem++) argvec[tem] = evaluate_subexp_with_coercion (exp, pos, noside); argvec[tem] = 0; /* signal end of arglist */ + if (noside == EVAL_SKIP) + goto nosideret; goto do_call_it; default: |