diff options
| author | Jiong Wang <jiong.wang@arm.com> | 2017-06-29 11:45:24 +0100 |
|---|---|---|
| committer | Jiong Wang <jiong.wang@arm.com> | 2017-06-29 11:45:24 +0100 |
| commit | 2aff25ba76035d2f1f48ea8a6c4b7e498ee31790 (patch) | |
| tree | 37844c556138183a2811f1f17e3025992ad5537b /bfd/ChangeLog | |
| parent | 88ab90e860a46a1123fcfd13bfe51cd360e9c3f7 (diff) | |
[AArch64] Remove duplicated code when handling some GOT relocations types
There are quite a few duplicated code supporting several GP based
relocation types. They are:
BFD_RELOC_AARCH64_LD64_GOTOFF_LO15
BFD_RELOC_AARCH64_MOVW_GOTOFF_G0_NC
BFD_RELOC_AARCH64_MOVW_GOTOFF_G1
These relocation types are supposed to be used for large memory model PIC/pic
mode under which we will have an initialized GP register points to the base of
GOT table, then these relocations are supposed to put the distance between GOT
entry and GOT table base address into the related instructions.
So, the parameters required to calculate the relocation should be the same as
BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15 etc, all of them are require the GOT entry
address and GOT table base address to perform the relocation.
This patch has removed those duplicated code when handling above listed
relocation types, grouped them with others as relocation types that are
require GOT table base address during performing relocation, reused the
existed GOT handling code.
The relocation calculation for these types before and after this patch should be
identical.
bfd/
* elfnn-aarch64.c (aarch64_relocation_aginst_gp_p): New function.
(elfNN_aarch64_final_link_relocate): Delete duplicated code for
BFD_RELOC_AARCH64_LD64_GOTOFF_LO15, BFD_RELOC_AARCH64_MOVW_GOTOFF_G0_NC,
BFD_RELOC_AARCH64_MOVW_GOTOFF_G1.
* elfxx-aarch64.c (_bfd_aarch64_elf_resolve_relocation): Optimize the
support for them.
Diffstat (limited to 'bfd/ChangeLog')
| -rw-r--r-- | bfd/ChangeLog | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 9c622354e1..8975b265ad 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,12 @@ +2017-06-29 Jiong Wang <jiong.wang@arm.com> + + * elfnn-aarch64.c (aarch64_relocation_aginst_gp_p): New function. + (elfNN_aarch64_final_link_relocate): Delete duplicated code for + BFD_RELOC_AARCH64_LD64_GOTOFF_LO15, BFD_RELOC_AARCH64_MOVW_GOTOFF_G0_NC, + BFD_RELOC_AARCH64_MOVW_GOTOFF_G1. + * elfxx-aarch64.c (_bfd_aarch64_elf_resolve_relocation): Optimize the + support for them. + 2017-06-29 Andreas Arnez <arnez@linux.vnet.ibm.com> * elf-bfd.h (elfcore_write_s390_gs_cb): Add prototype. |