diff options
| author | Isaku Yamahata <yamahata@valinux.co.jp> | 2012-10-16 06:57:27 +0900 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2012-10-16 10:19:49 -0700 |
| commit | 378cc7f11274b21e6cc837129166b24a5281aa3c (patch) | |
| tree | 7c7b49c958f795be8b8c82e7462329003cd7234d /python | |
| parent | 93ea780907c2c4315ecc1a3e7823fcba3aba5e96 (diff) | |
python/ovs/socket_util: don't use Exception, but ValueError
67656b9ff297f305b3bfcca2868e8e870e108283
used Exception, but it should be more specific error.
Use ValueError instread of Exception.
Suggested-by: Reid Price <reid@nicira.com>
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'python')
| -rw-r--r-- | python/ovs/socket_util.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/python/ovs/socket_util.py b/python/ovs/socket_util.py index 845511e3..dd45fe4b 100644 --- a/python/ovs/socket_util.py +++ b/python/ovs/socket_util.py @@ -88,13 +88,13 @@ def inet_parse_active(target, default_port): address = target.split(":") host_name = address[0] if not host_name: - raise Exception("%s: bad peer name format" % target) + raise ValueError("%s: bad peer name format" % target) if len(address) >= 2: port = int(address[1]) elif default_port: port = default_port else: - raise Exception("%s: port number must be specified" % target) + raise ValueError("%s: port number must be specified" % target) return (host_name, port) @@ -187,6 +187,6 @@ def set_nonblocking(sock): def set_dscp(sock, dscp): if dscp > 63: - raise Exception("Invalid dscp %d" % dscp) + raise ValueError("Invalid dscp %d" % dscp) val = dscp << 2 sock.setsockopt(socket.IPPROTO_IP, socket.IP_TOS, val) |