diff options
| author | Ben Pfaff <blp@nicira.com> | 2013-08-23 11:11:03 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2013-08-23 11:11:03 -0700 |
| commit | 9e404d1e1c7d36f0746de29ccc6fa57bc4696fda (patch) | |
| tree | c27a9923f3030252ba8123de633007a98897703c /lib/ofp-errors.h | |
| parent | bb61b33de6d6b8488aabf76419371a13ddecde36 (diff) | |
meta-flow: Use correct OF1.2+ errors for invalid fields in actions.
OFPERR_OFPBAC_BAD_ARGUMENT is not as specific as the errors provided by
OpenFlow 1.2 and later.
Some of these errors needed Nicira extension numbers for use with OpenFlow
1.0 and 1.1, so this commit also adds those.
Some of these errors had poor explanations likely to confuse users, so this
commits improves them.
Some of the errors had the wrong names, so this commit fixes them.
Reported-by: Jean Tourrilhes <jt@hpl.hp.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jean Tourrilhes <jt@hpl.hp.com>
Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
Diffstat (limited to 'lib/ofp-errors.h')
| -rw-r--r-- | lib/ofp-errors.h | 18 |
1 files changed, 11 insertions, 7 deletions
diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h index 5bf5826d..79acd303 100644 --- a/lib/ofp-errors.h +++ b/lib/ofp-errors.h @@ -214,7 +214,8 @@ enum ofperr { /* OF1.1+(2,9). Invalid group id in forward action. */ OFPERR_OFPBAC_BAD_OUT_GROUP, - /* OF1.1+(2,10). Action can't apply for this match. */ + /* NX1.0(1,522), OF1.1+(2,10). Action can't apply for this match or a + * prerequisite for use of this field is unmet. */ OFPERR_OFPBAC_MATCH_INCONSISTENT, /* OF1.1+(2,11). Action order is unsupported for the action list in an @@ -224,14 +225,17 @@ enum ofperr { /* OF1.1+(2,12). Actions uses an unsupported tag/encap. */ OFPERR_OFPBAC_BAD_TAG, - /* OF1.2+(2,13). Unsupported type in SET_FIELD action. */ - OFPERR_OFPBAC_SET_TYPE, + /* NX1.0-1.1(1,523), OF1.2+(2,13). Action uses unknown or unsupported OXM + * or NXM field. */ + OFPERR_OFPBAC_BAD_SET_TYPE, - /* OF1.2+(2,14). Length problem in SET_FIELD action. */ - OFPERR_OFPBAC_SET_LEN, + /* NX1.0-1.1(1,524), OF1.2+(2,14). Action references past the end of an + * OXM or NXM field, or uses a length of zero. */ + OFPERR_OFPBAC_BAD_SET_LEN, - /* OF1.2+(2,15). Bad argument in SET_FIELD action. */ - OFPERR_OFPBAC_ARGUMENT, + /* NX1.0-1.1(1,525), OF1.2+(2,15). Action sets a field to an invalid or + * unsupported value, or modifies a read-only field. */ + OFPERR_OFPBAC_BAD_SET_ARGUMENT, /* NX1.0-1.1(2,256), NX1.2+(11). Must-be-zero action argument had nonzero * value. */ |