diff options
| author | Simon Horman <horms@verge.net.au> | 2012-09-05 11:50:37 +0900 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2012-09-05 10:19:03 -0700 |
| commit | 2e1bfcb6315704b804add452ca6d1324dac5b45c (patch) | |
| tree | cd4fcd27beda54fc272c02637f1df49a7f0046e8 /lib/ofp-errors.h | |
| parent | 55c2b94431412e6ffb2010bad230f68373109e07 (diff) | |
ofp-errors: Use OFPERR_OFPBRC_BAD_PORT
* In the case of OpenFlow 1.2+ OFPERR_OFPBRC_BAD_PORT is defined
in the specification and seems to be the most appropriate error
to use when an invalid port is encountered in a Packet Out request.
* In the case of OpenFlow 1.0 and 1.1 no appropriate error message
seems to exist. Perhaps because an invalid port is not possible?
I'm unsure.
In any case, make use of a non-standard error code (1,514).
This was formerly known as OFPERR_NXBRC_BAD_IN_PORT but
has been rolled into OFPERR_NXBRC_BAD_IN_PORT to allow the
latter to be used without concern for the prevailing Open Flow version.
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'lib/ofp-errors.h')
| -rw-r--r-- | lib/ofp-errors.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h index e361223b..9a5dbcb0 100644 --- a/lib/ofp-errors.h +++ b/lib/ofp-errors.h @@ -118,7 +118,10 @@ enum ofperr { /* OF1.2+(1,10). Denied because controller is slave. */ OFPERR_OFPBRC_IS_SLAVE, - /* OF1.2+(1,11). Invalid port. */ + /* NX1.0(1,514), NX1.1(1,514), OF1.2+(1,11). Invalid port. + * [ A non-standard error (1,514), formerly + * OFPERR_NXBRC_BAD_IN_PORT is used for OpenFlow 1.0 and 1.1 as there + * seems to be no appropriste error code defined the specifications. ] */ OFPERR_OFPBRC_BAD_PORT, /* OF1.2+(1,12). Invalid packet in packet-out. */ @@ -134,9 +137,6 @@ enum ofperr { /* NX1.0+(1,512). A request specified a nonexistent table ID. */ OFPERR_NXBRC_BAD_TABLE_ID, - /* NX1.0+(1,514). The in_port in an ofp_packet_out request is invalid. */ - OFPERR_NXBRC_BAD_IN_PORT, - /* NX1.0+(1,515). Must-be-zero field had nonzero value. */ OFPERR_NXBRC_MUST_BE_ZERO, |