diff options
author | Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org> | 2017-07-25 20:57:39 +0300 |
---|---|---|
committer | Maxim Uvarov <maxim.uvarov@linaro.org> | 2017-07-27 17:24:29 +0300 |
commit | ed136f929f0edf2edd4bb8cf2243b678b5f5971e (patch) | |
tree | e4ecc15ddd00e1f316ce422033df00ad59477c71 | |
parent | c84d3a864bf6471b2a1d433ad378c3b609460e5d (diff) |
configure: remove non-standard test usage
According to POSIX it is correct to check for string equality using one
equal sign, not two signs. POSIX-strict shells will return incorrect
result on such constructions.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>
Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
-rw-r--r-- | configure.ac | 6 | ||||
-rw-r--r-- | platform/linux-generic/m4/odp_pcap.m4 | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/configure.ac b/configure.ac index e4903c7a8..51dd9352e 100644 --- a/configure.ac +++ b/configure.ac @@ -115,7 +115,7 @@ AC_SUBST([ARCH_DIR]) ########################################################################## # Warn on the defaults if arch is undefined ########################################################################## -if test "${ARCH_DIR}" == "undefined"; +if test "${ARCH_DIR}" = "undefined"; then echo "ARCH_DIR is undefined, please add your ARCH_DIR based on host=${host}" exit 1 @@ -135,7 +135,7 @@ AS_CASE([$host], ) AC_SUBST([ARCH_ABI]) -if test "${ARCH_ABI}" == "undefined"; +if test "${ARCH_ABI}" = "undefined"; then echo "ARCH_ABI is undefined, please add your ARCH_ABI based on host=${host}" exit 1 @@ -164,7 +164,7 @@ AC_SUBST([platform_with_platform], ["platform/${with_platform}"]) # Run platform specific checks and settings ########################################################################## IMPLEMENTATION_NAME="" -if test "${with_platform}" == "linux-generic"; +if test "${with_platform}" = "linux-generic"; then m4_include([./platform/linux-generic/m4/configure.m4]) m4_include([./test/linux-generic/m4/configure.m4]) diff --git a/platform/linux-generic/m4/odp_pcap.m4 b/platform/linux-generic/m4/odp_pcap.m4 index ffdff17c4..d7295f21b 100644 --- a/platform/linux-generic/m4/odp_pcap.m4 +++ b/platform/linux-generic/m4/odp_pcap.m4 @@ -8,7 +8,7 @@ AC_CHECK_HEADER(pcap/pcap.h, [])], []) -if test $have_pcap == yes; then +if test "$have_pcap" = "yes"; then ODP_CFLAGS="$AM_CFLAGS -DHAVE_PCAP" PCAP_LIBS="-lpcap" fi |