diff options
author | dlsmith <none@none> | 2014-06-10 15:25:01 -0600 |
---|---|---|
committer | dlsmith <none@none> | 2014-06-10 15:25:01 -0600 |
commit | bb87e258f23d6a6e124923ae3a75a3a9d195ee78 (patch) | |
tree | 49b97942620504d614224e4a3541dc67559928df | |
parent | fbb7460800b17fe7617aeb3604728632a8e72039 (diff) |
8015101: Covariance of return type implied by upper bounding on type parameter is ignored
Summary: Capture intersection supertypes before comparing their members
Reviewed-by: vromero
-rw-r--r-- | src/share/classes/com/sun/tools/javac/comp/Check.java | 5 | ||||
-rw-r--r-- | test/tools/javac/generics/wildcards/7034495/T7034495.out | 2 | ||||
-rw-r--r-- | test/tools/javac/generics/wildcards/T8015101.java | 44 |
3 files changed, 50 insertions, 1 deletions
diff --git a/src/share/classes/com/sun/tools/javac/comp/Check.java b/src/share/classes/com/sun/tools/javac/comp/Check.java index f89806f7..56033cfe 100644 --- a/src/share/classes/com/sun/tools/javac/comp/Check.java +++ b/src/share/classes/com/sun/tools/javac/comp/Check.java @@ -1813,6 +1813,11 @@ public class Check { Type t1, Type t2, Type site) { + if ((site.tsym.flags() & COMPOUND) != 0) { + // special case for intersections: need to eliminate wildcards in supertypes + t1 = types.capture(t1); + t2 = types.capture(t2); + } return firstIncompatibility(pos, t1, t2, site) == null; } diff --git a/test/tools/javac/generics/wildcards/7034495/T7034495.out b/test/tools/javac/generics/wildcards/7034495/T7034495.out index 39c6f7fa..58aa1f67 100644 --- a/test/tools/javac/generics/wildcards/7034495/T7034495.out +++ b/test/tools/javac/generics/wildcards/7034495/T7034495.out @@ -1,2 +1,2 @@ -T7034495.java:40:17: compiler.err.types.incompatible.diff.ret: T7034495.B<?>, T7034495.A<?>, foo() +T7034495.java:40:17: compiler.err.types.incompatible.diff.ret: T7034495.B<compiler.misc.type.captureof: 1, ?>, T7034495.A<compiler.misc.type.captureof: 2, ?>, foo() 1 error diff --git a/test/tools/javac/generics/wildcards/T8015101.java b/test/tools/javac/generics/wildcards/T8015101.java new file mode 100644 index 00000000..02409a5d --- /dev/null +++ b/test/tools/javac/generics/wildcards/T8015101.java @@ -0,0 +1,44 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8015101 + * @summary Mishandling of wildcards in intersection member method check + * @compile T8015101.java + */ +class T8015101 { + + public static class Bug<X extends Child<?, ?> & Runnable> { + } + + interface Parent<C> { + public C get(); + } + + interface Child<C, S extends C> extends Parent<C> { + @Override + public S get(); + } + + } |