diff options
author | Parth Chandra <parthc@apache.org> | 2018-06-02 17:41:45 -0700 |
---|---|---|
committer | Parth Chandra <parthc@apache.org> | 2018-06-02 17:41:45 -0700 |
commit | 9dceecff3957be6fed409ef10cb52e05e4cdb0fd (patch) | |
tree | d7d83a242ad9fddff35f02120216c053ceaa8c0b /contrib/storage-hbase/src | |
parent | 9908ea035a6a9512ddf005fc402b07a7101243db (diff) |
Revert "DRILL-4020: The not-equal operator returns incorrect results when used on the HBase row key"
This reverts commit 0d5eda83fe34928ff60629e6a4903d43a1d82582.
Diffstat (limited to 'contrib/storage-hbase/src')
2 files changed, 0 insertions, 19 deletions
diff --git a/contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseFilterBuilder.java b/contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseFilterBuilder.java index 6e1efe512..8d2e8ffd7 100644 --- a/contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseFilterBuilder.java +++ b/contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseFilterBuilder.java @@ -61,7 +61,6 @@ public class HBaseFilterBuilder extends AbstractExprVisitor<HBaseScanSpec, Void, * remove it since its effect is also achieved through startRow and stopRow. */ if (parsedSpec.filter instanceof RowFilter && - ((RowFilter)parsedSpec.filter).getOperator() != CompareOp.NOT_EQUAL && ((RowFilter)parsedSpec.filter).getComparator() instanceof BinaryComparator) { parsedSpec.filter = null; } diff --git a/contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseFilterPushDown.java b/contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseFilterPushDown.java index e70cf08e8..0e14cb183 100644 --- a/contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseFilterPushDown.java +++ b/contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestHBaseFilterPushDown.java @@ -45,24 +45,6 @@ public class TestHBaseFilterPushDown extends BaseHBaseTest { } @Test - public void testFilterPushDownRowKeyNotEqual() throws Exception { - setColumnWidths(new int[] {8, 38, 38}); - final String sql = "SELECT\n" - + " *\n" - + "FROM\n" - + " hbase.`[TABLE_NAME]` tableName\n" - + "WHERE\n" - + " row_key <> 'b4'"; - - runHBaseSQLVerifyCount(sql, 6); - - final String[] expectedPlan = {".*startRow=, stopRow=, filter=RowFilter \\(NOT_EQUAL, b4\\).*"}; - final String[] excludedPlan ={}; - final String sqlHBase = canonizeHBaseSQL(sql); - PlanTestBase.testPlanMatchingPatterns(sqlHBase, expectedPlan, excludedPlan); - } - - @Test public void testFilterPushDownRowKeyEqualWithItem() throws Exception { setColumnWidths(new int[] {20, 30}); final String sql = "SELECT\n" |