diff options
| author | Etienne Carriere <etienne.carriere@linaro.org> | 2020-04-30 16:59:27 +0200 |
|---|---|---|
| committer | Jerome Forissier <jerome@forissier.org> | 2020-05-04 08:47:42 +0200 |
| commit | 187ba5c22ffb5166324e18eab259dc891ffff2d6 (patch) | |
| tree | 988607c656e339061722dc89c43c40845dd55a38 | |
| parent | ed3fa831cdd6c545bf2813de8aeccc2564387983 (diff) | |
stpmic1: fix missing parentheses in boot-on config
Fix error reported by GCC [1]:
core/drivers/stpmic1.c: In function ‘stpmic1_bo_voltage_unpg’:
core/drivers/stpmic1.c:720:24: error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses]
if (value & cfg->mask >= cfg->min_value)
~~~~~~~~~~^~~~~~~~~~~~~~~~~
[1] arm-buildroot-linux-uclibcgnueabihf-gcc.br_real (Buildroot
2019.11-git-01409-gab8f872d0e-dirty) 8.3.0
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Jerome Forissier <jerome@forissier.org>
[jf: wrap compiler description line]
Signed-off-by: Jerome Forissier <jerome@forissier.org>
| -rw-r--r-- | core/drivers/stpmic1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/core/drivers/stpmic1.c b/core/drivers/stpmic1.c index 5681003b..40586fc3 100644 --- a/core/drivers/stpmic1.c +++ b/core/drivers/stpmic1.c @@ -721,7 +721,7 @@ int stpmic1_bo_voltage_unpg(struct stpmic1_bo_cfg *cfg) if (stpmic1_register_read(cfg->ctrl_reg, &value)) return -1; - if (value & cfg->mask >= cfg->min_value) + if ((value & cfg->mask) >= cfg->min_value) return 0; return stpmic1_register_update(cfg->ctrl_reg, cfg->min_value, |