aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2012-01-25 11:08:40 +0100
committerSteven Rostedt <rostedt@goodmis.org>2013-11-13 11:21:06 -0500
commitd167b2755864fad492a11dc737d37c01162ee515 (patch)
tree8e15097b2d5ad1828465d4739c6c424e7bfbce82
parenta6e644add9741bf5746c6e310ac9ea68e558efed (diff)
timer-fd: Prevent live lock
If hrtimer_try_to_cancel() requires a retry, then depending on the priority setting te retry loop might prevent timer callback completion on RT. Prevent that by waiting for completion on RT, no change for a non RT kernel. Reported-by: Sankara Muthukrishnan <sankara.m@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: stable-rt@vger.kernel.org
-rw-r--r--fs/timerfd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/timerfd.c b/fs/timerfd.c
index 32b644f03690..1844c9733e44 100644
--- a/fs/timerfd.c
+++ b/fs/timerfd.c
@@ -308,7 +308,7 @@ static int do_timerfd_settime(int ufd, int flags,
if (hrtimer_try_to_cancel(&ctx->tmr) >= 0)
break;
spin_unlock_irq(&ctx->wqh.lock);
- cpu_relax();
+ hrtimer_wait_for_timer(&ctx->tmr);
}
/*