diff options
| author | NeilBrown <neilb@suse.de> | 2010-11-24 16:39:46 +1100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-12-09 13:32:39 -0800 |
| commit | 5c123e20b4e588a273b9cb16c24c3aac8cdb91b3 (patch) | |
| tree | 270030805303dffc56749b48d2ccf6971e5b3401 | |
| parent | 3743e8ce777f4f1cfa1797dc1d96a4e94b361a11 (diff) | |
md/raid1: really fix recovery looping when single good device fails.
commit 8f9e0ee38f75d4740daa9e42c8af628d33d19a02 upstream.
Commit 4044ba58dd15cb01797c4fd034f39ef4a75f7cc3 supposedly fixed a
problem where if a raid1 with just one good device gets a read-error
during recovery, the recovery would abort and immediately restart in
an infinite loop.
However it depended on raid1_remove_disk removing the spare device
from the array. But that does not happen in this case. So add a test
so that in the 'recovery_disabled' case, the device will be removed.
This suitable for any kernel since 2.6.29 which is when
recovery_disabled was introduced.
Reported-by: Sebastian Färber <faerber@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/md/raid1.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 0b830bbe1d8..d8b2d7b0c3b 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -1210,6 +1210,7 @@ static int raid1_remove_disk(mddev_t *mddev, int number) * is not possible. */ if (!test_bit(Faulty, &rdev->flags) && + !mddev->recovery_disabled && mddev->degraded < conf->raid_disks) { err = -EBUSY; goto abort; |