diff options
| author | Mads Kiilerich <madski@unity3d.com> | 2013-03-28 01:10:45 +0100 |
|---|---|---|
| committer | Mads Kiilerich <madski@unity3d.com> | 2013-03-28 01:10:45 +0100 |
| commit | ca605a881e3f82dabf377ded30d6127a29b801a0 (patch) | |
| tree | 666619b56bfbdf68ca4893e2ab90a4deb0ca12df /rhodecode/tests | |
| parent | 0829b12f18e335f9d78d480cdee3a3e5dc4ec3eb (diff) | |
follow Python conventions for boolean values
True and False might be singletons and the "default" values for "boolean"
expressions, but "all" values in Python has a boolean value and should be
evaluated as such. Checking with 'is True' and 'is False' is thus confusing,
error prone and unnessarily complex.
If we anywhere rely and nullable boolean fields from the database layer and
don't want the null value to be treated as False then we should check
explicitly for null with 'is None'.
--HG--
branch : beta
Diffstat (limited to 'rhodecode/tests')
| -rw-r--r-- | rhodecode/tests/scripts/test_concurency.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rhodecode/tests/scripts/test_concurency.py b/rhodecode/tests/scripts/test_concurency.py index 224f508e..c057f2e2 100644 --- a/rhodecode/tests/scripts/test_concurency.py +++ b/rhodecode/tests/scripts/test_concurency.py @@ -183,7 +183,7 @@ def test_clone_with_credentials(no_errors=False, repo=HG_REPO, method=METHOD, else: stdout, stderr = Command(cwd).execute(backend, method, clone_url, dest) print stdout,'sdasdsadsa' - if no_errors is False: + if not no_errors: if backend == 'hg': assert """adding file changes""" in stdout, 'no messages about cloning' assert """abort""" not in stderr , 'got error from clone' |