diff options
| author | Marcin Kuzminski <marcin@python-works.com> | 2013-03-28 03:34:36 +0100 |
|---|---|---|
| committer | Marcin Kuzminski <marcin@python-works.com> | 2013-03-28 03:34:36 +0100 |
| commit | 09fd3f2872f4ff7c42cca696e8afb42d8fb1a259 (patch) | |
| tree | d8da8ab5637717d0dbbd5f3ef9bf4d295726691c /rhodecode/tests | |
| parent | aa0468b7bdbc776dcd821451d3b4645ec13c2293 (diff) | |
Don't catch all exceptions
--HG--
branch : beta
Diffstat (limited to 'rhodecode/tests')
| -rw-r--r-- | rhodecode/tests/functional/test_admin_repos.py | 14 | ||||
| -rw-r--r-- | rhodecode/tests/scripts/test_concurency.py | 4 |
2 files changed, 9 insertions, 9 deletions
diff --git a/rhodecode/tests/functional/test_admin_repos.py b/rhodecode/tests/functional/test_admin_repos.py index c98e0f40..3ad98d45 100644 --- a/rhodecode/tests/functional/test_admin_repos.py +++ b/rhodecode/tests/functional/test_admin_repos.py @@ -61,7 +61,7 @@ class TestAdminReposController(TestController): #test if repository was created on filesystem try: vcs.get_repo(os.path.join(TESTS_TMP_PATH, repo_name)) - except: + except Exception: self.fail('no repo %s in filesystem' % repo_name) def test_create_hg_non_ascii(self): @@ -94,7 +94,7 @@ class TestAdminReposController(TestController): #test if repository was created on filesystem try: vcs.get_repo(os.path.join(TESTS_TMP_PATH, repo_name)) - except: + except Exception: self.fail('no repo %s in filesystem' % repo_name) def test_create_hg_in_group(self): @@ -134,7 +134,7 @@ class TestAdminReposController(TestController): #test if repository was created on filesystem try: vcs.get_repo(os.path.join(TESTS_TMP_PATH, repo_name_full)) - except: + except Exception: ReposGroupModel().delete(group_name) self.Session().commit() self.fail('no repo %s in filesystem' % repo_name) @@ -172,7 +172,7 @@ class TestAdminReposController(TestController): #test if repository was created on filesystem try: vcs.get_repo(os.path.join(TESTS_TMP_PATH, repo_name)) - except: + except Exception: self.fail('no repo %s in filesystem' % repo_name) def test_create_git_non_ascii(self): @@ -208,7 +208,7 @@ class TestAdminReposController(TestController): #test if repository was created on filesystem try: vcs.get_repo(os.path.join(TESTS_TMP_PATH, repo_name)) - except: + except Exception: self.fail('no repo %s in filesystem' % repo_name) def test_update(self): @@ -246,7 +246,7 @@ class TestAdminReposController(TestController): #test if repository was created on filesystem try: vcs.get_repo(os.path.join(TESTS_TMP_PATH, repo_name)) - except: + except Exception: self.fail('no repo %s in filesystem' % repo_name) response = self.app.delete(url('repo', repo_name=repo_name)) @@ -294,7 +294,7 @@ class TestAdminReposController(TestController): #test if repository was created on filesystem try: vcs.get_repo(os.path.join(TESTS_TMP_PATH, repo_name)) - except: + except Exception: self.fail('no repo %s in filesystem' % repo_name) response = self.app.delete(url('repo', repo_name=repo_name)) diff --git a/rhodecode/tests/scripts/test_concurency.py b/rhodecode/tests/scripts/test_concurency.py index c057f2e2..8268810d 100644 --- a/rhodecode/tests/scripts/test_concurency.py +++ b/rhodecode/tests/scripts/test_concurency.py @@ -198,12 +198,12 @@ if __name__ == '__main__': try: METHOD = sys.argv[3] - except: + except Exception: pass try: backend = sys.argv[4] - except: + except Exception: backend = 'hg' if METHOD == 'pull': |