diff options
author | Marcin Kuzminski <marcin@python-works.com> | 2013-03-27 19:38:05 +0100 |
---|---|---|
committer | Marcin Kuzminski <marcin@python-works.com> | 2013-03-27 19:38:05 +0100 |
commit | eb051ff346feada6904117f4d4432d01e073aa0f (patch) | |
tree | c927eef1c55d46c6306c64d15ba10956ab8cfcf5 | |
parent | 712b55926ffa3578cea002eac7cb984a0e552769 (diff) |
missing changesets should return 404 not redirect + flash.
It feels more correct.
--HG--
branch : beta
extra : amend_source : 9d78bb57edb8db82b5a3b8b371701c71fb7d99d7
-rw-r--r-- | rhodecode/controllers/changeset.py | 4 | ||||
-rwxr-xr-x | rhodecode/templates/errors/error_document.html | 20 |
2 files changed, 12 insertions, 12 deletions
diff --git a/rhodecode/controllers/changeset.py b/rhodecode/controllers/changeset.py index 56d3d7b0..b3107f50 100644 --- a/rhodecode/controllers/changeset.py +++ b/rhodecode/controllers/changeset.py @@ -26,7 +26,7 @@ import logging import traceback from collections import defaultdict -from webob.exc import HTTPForbidden, HTTPBadRequest +from webob.exc import HTTPForbidden, HTTPBadRequest, HTTPNotFound from pylons import tmpl_context as c, url, request, response from pylons.i18n.translation import _ @@ -204,7 +204,7 @@ class ChangesetController(BaseRepoController): except (RepositoryError, ChangesetDoesNotExistError, Exception), e: log.error(traceback.format_exc()) h.flash(str(e), category='error') - return redirect(url('changeset_home', repo_name=c.repo_name)) + raise HTTPNotFound() c.changes = OrderedDict() diff --git a/rhodecode/templates/errors/error_document.html b/rhodecode/templates/errors/error_document.html index 5813aac6..8959dc26 100755 --- a/rhodecode/templates/errors/error_document.html +++ b/rhodecode/templates/errors/error_document.html @@ -33,16 +33,16 @@ </head> <body> - <div class="flash_msg"> - <% messages = h.flash.pop_messages() %> - % if messages: - <ul id="flash-messages"> - % for message in messages: - <li class="${message.category}_msg">${message}</li> - % endfor - </ul> - % endif - </div> + <div class="flash_msg"> + <% messages = h.flash.pop_messages() %> + % if messages: + <ul id="flash-messages"> + % for message in messages: + <li class="${message.category}_msg">${message}</li> + % endfor + </ul> + % endif + </div> <div id="login"> <div class="table"> <div id="main_div"> |