Two more tests added for getTheme method. Also refactored the code so the test with exceptions work.

2 files changed, 37 insertions, 3 deletions

diff --git a/licenses/LicenseHelper.php b/licenses/LicenseHelper.php
index 64fa87a..1329ff9 100644
--- a/licenses/LicenseHelper.php
+++ b/licenses/LicenseHelper.php
@@ -15,6 +15,10 @@ class LicenseHelper
 
   public static function getFilesList($dirname)
   {
+    if (!is_dir($dirname)) {
+      throw new InvalidArgumentException('Method argument should be a directory path');
+    }
+
     $files = array(); 
     if ($handle = opendir($dirname)) {
       while ($handle && false !== ($entry = readdir($handle))) {
diff --git a/testing/LicenseHelperTest.php b/testing/LicenseHelperTest.php
index c44a4ae..650cdb0 100644
--- a/testing/LicenseHelperTest.php
+++ b/testing/LicenseHelperTest.php
@@ -49,8 +49,14 @@ class LicenseHelperTest extends PHPUnit_Framework_TestCase
    */
   public function testGetFilesList_file()
   {
-    $file_list = LicenseHelper::getFilesList(__FILE__);
-    $this->assertEmpty($file_list);
+    try {
+      $file_list = LicenseHelper::getFilesList(__FILE__);
+      $this->assertTrue(FALSE);
+    } catch (InvalidArgumentException $e) {
+      $this->assertTrue(TRUE);
+    } catch (Exception $e) {
+      $this->assertTrue(FALSE);
+    }
   }
 
   /**
@@ -84,7 +90,31 @@ class LicenseHelperTest extends PHPUnit_Framework_TestCase
   {
     $file_list = array("test.txt", "new_file.pdf");
     $pattern = "/test/";
-    $this->assertEquals("test.txt", LicenseHelper::findFileByPattern($file_list, $pattern));
+    $this->assertEquals("test.txt", 
+			LicenseHelper::findFileByPattern($file_list, $pattern));
+  }
+
+  /**
+   * Test with no eula present.
+   */
+  public function testGetTheme_noEula()
+  {
+    $eula = "EULA.txt";
+    $filename = "snowball.build.tar.bz2";
+    $this->assertEquals("ste", LicenseHelper::getTheme($eula, $filename));
+    $filename = "origen.build.tar.bz2";
+    $this->assertEquals("samsung", LicenseHelper::getTheme($eula, $filename));
+    $filename = "build.tar.bz2";
+    $this->assertEquals("linaro", LicenseHelper::getTheme($eula, $filename));
+  }
+
+  /**
+   * Test with eula present.
+   */
+  public function testGetTheme_eula()
+  {
+    $eula = "EULA.txt.test";
+    $this->assertEquals("test", LicenseHelper::getTheme($eula, ""));
   }
 
 }