diff options
author | Milo Casagrande <milo.casagrande@linaro.org> | 2014-12-05 10:32:39 +0100 |
---|---|---|
committer | Milo Casagrande <milo.casagrande@linaro.org> | 2014-12-05 10:32:39 +0100 |
commit | be28728a4fb1172e45144f2c081362b5511a0dbc (patch) | |
tree | 86a0c2ed42702d8519ef59cfd7415fcc27c2da2d | |
parent | 9f7cef4beedf320d4519b7ef26c83f935c704ddf (diff) |
Fix jslint errors.
Change-Id: I577e27a2443ed20bcf998d9a34b39e6b2abae647
-rw-r--r-- | app/dashboard/static/js/linaro-builds-job-kernel-1.0.7.js | 76 |
1 files changed, 39 insertions, 37 deletions
diff --git a/app/dashboard/static/js/linaro-builds-job-kernel-1.0.7.js b/app/dashboard/static/js/linaro-builds-job-kernel-1.0.7.js index 55ca3e2..377155a 100644 --- a/app/dashboard/static/js/linaro-builds-job-kernel-1.0.7.js +++ b/app/dashboard/static/js/linaro-builds-job-kernel-1.0.7.js @@ -73,36 +73,38 @@ function createPieChart(data) { pie = d3.layout.pie().sort(null), arc = d3.svg.arc().innerRadius(radius - 30).outerRadius(radius - 50); - for (i; i < len; i++) { - switch (data[i].status) { - case 'FAIL': - fail++; - break; - case 'PASS': - success++; - break; - default: - unknown++; - break; + if (len > 0) { + for (i; i < len; i = i + 1) { + switch (data[i].status) { + case 'FAIL': + fail = fail + 1; + break; + case 'PASS': + success = success + 1; + break; + default: + unknown = unknown + 1; + break; + } } - } - dataset = [success, fail, unknown]; - svg = d3.select('#builds-chart').append('svg') - .attr('width', width) - .attr('height', height) - .append('g') - .attr('transform', 'translate(' + width / 2 + ',' + - height / 2 + ')' - ); - - svg.selectAll('path') - .data(pie(dataset)) - .enter().append('path') - .attr('fill', function(d, i) { - return color[i]; - }) - .attr('d', arc); + dataset = [success, fail, unknown]; + svg = d3.select('#builds-chart').append('svg') + .attr('width', width) + .attr('height', height) + .append('g') + .attr('transform', 'translate(' + width / 2 + ',' + + height / 2 + ')' + ); + + svg.selectAll('path') + .data(pie(dataset)) + .enter().append('path') + .attr('fill', function(d, i) { + return color[i]; + }) + .attr('d', arc); + } $('#success-cell') .empty() @@ -150,7 +152,7 @@ function createBuildsPage(data) { '<li class="fa fa-question"></li></span>', archLabel = ''; - for (i; i < len; i++) { + for (i; i < len; i = i + 1) { localData = data[i]; defconfigFull = localData.defconfig_full; @@ -361,14 +363,14 @@ $(document).ready(function() { $(document).ready(function() { // No use strict here, or onbeforeunload is not recognized. - var session_state = new SessionState(jobId); + var sessionState = new SessionState(jobId); onbeforeunload = function() { - var panel_state = {}, - page_state; + var panelState = {}, + pageState; $('[id^="panel-defconf"]').each(function(id) { - panel_state['#panel-defconf' + id] = { + panelState['#panel-defconf' + id] = { 'type': 'class', 'name': 'class', 'value': $('#panel-defconf' + id).attr('class') @@ -376,14 +378,14 @@ $(document).ready(function() { }); $('[id^="collapse-defconf"]').each(function(id) { - panel_state['#collapse-defconf' + id] = { + panelState['#collapse-defconf' + id] = { 'type': 'class', 'name': 'class', 'value': $('#collapse-defconf' + id).attr('class') }; }); - page_state = { + pageState = { '.df-success': { 'type': 'attr', 'name': 'style', @@ -421,7 +423,7 @@ $(document).ready(function() { } }; - session_state.objects = collectObjects(panel_state, page_state); - saveToSessionStorage(session_state); + sessionState.objects = collectObjects(panelState, pageState); + saveToSessionStorage(sessionState); }; }); |