aboutsummaryrefslogtreecommitdiff
path: root/drivers/misc
diff options
context:
space:
mode:
authorChethan Krishna N <chethan.krishna@stericsson.com>2011-03-15 11:58:24 +0530
committerRobert Marklund <robert.marklund@stericsson.com>2011-10-05 11:18:14 +0200
commita0626682c27550b1a44054509b078e4fd83d7088 (patch)
tree9e896cb0798cb80d4686c45b08e626e665517bc5 /drivers/misc
parent252c29cd74dcc4dc73097e49de0df6b9a69a95a4 (diff)
bh1780gli: correct mutex locking behaviour
Multiple activation and deactivation calls for BH1780GLI Ambient Light Sensor will not crash now. ST Ericsson ID: ER326054 Signed-off-by: Chethan Krishna N <chethan.krishna@stericsson.com> Change-Id: I3bfeb6a371ae567e14300339b1b18dc750a59b14 Reviewed-on: http://gerrit.lud.stericsson.com/gerrit/18319 Reviewed-by: Srinidhi KASAGAR <srinidhi.kasagar@stericsson.com>
Diffstat (limited to 'drivers/misc')
-rw-r--r--drivers/misc/bh1780gli.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/misc/bh1780gli.c b/drivers/misc/bh1780gli.c
index 1e495bfd7a7..0a731371fb5 100644
--- a/drivers/misc/bh1780gli.c
+++ b/drivers/misc/bh1780gli.c
@@ -115,11 +115,11 @@ static ssize_t bh1780_store_power_state(struct device *dev,
if (val < BH1780_POFF || val > BH1780_PON)
return -EINVAL;
- mutex_lock(&ddata->lock);
-
if (ddata->power_state == val)
return count;
+ mutex_lock(&ddata->lock);
+
if (ddata->power_state == BH1780_POFF)
regulator_enable(ddata->regulator);