Merge branch 'tianocore-edk2-basetools'linaro-base-2013.04linaro-base-2013.03

7 files changed, 302 insertions, 51 deletions

diff --git a/BaseTools/Contributions.txt b/BaseTools/Contributions.txt
new file mode 100644
index 0000000000..667ca1035c
--- /dev/null
+++ b/BaseTools/Contributions.txt
@@ -0,0 +1,188 @@
+

+======================

+= Code Contributions =

+======================

+

+To make a contribution to a TianoCore project, follow these steps.

+1. Create a change description in the format specified below to

+   use in the source control commit log.

+2. Your commit message must include your "Signed-off-by" signature,

+   and "Contributed-under" message.

+3. Your "Contributed-under" message explicitly states that the

+   contribution is made under the terms of the specified

+   contribution agreement.  Your "Contributed-under" message

+   must include the name of contribution agreement and version.

+   For example: Contributed-under: TianoCore Contribution Agreement 1.0

+   The "TianoCore Contribution Agreement" is included below in

+   this document.

+4. Submit your code to the TianoCore project using the process

+   that the project documents on its web page.  If the process is

+   not documented, then submit the code on development email list

+   for the project.

+

+=======================================

+= Change Description / Commit Message =

+=======================================

+

+Your change description should use the standard format for a

+commit message, and must include your "Signed-off-by" signature

+and the "Contributed-under" message.

+

+== Sample Change Description / Commit Message =

+

+=== Definitions for sample change description ===

+

+* "CodeModule" is a short idenfier for the affected code.  For

+  example MdePkg, or MdeModulePkg UsbBusDxe.

+* "Brief-single-line-summary" is a short summary of the change.

+* The entire first line should be less than ~70 characters.

+* "Full-commit-message" a verbose multiple line comment describing

+  the change.  Each line should be less than ~70 characters.

+* "Contributed-under" explicitely states that the contribution is

+  made under the terms of the contribtion agreement.  This

+  agreement is included below in this document.

+* "Signed-off-by" is the contributor's signature identifying them

+  by their real/legal name and their email address.

+

+=== Start of sample change description / commit message ===

+CodeModule: Brief-single-line-summary

+

+Full-commit-message

+

+Contributed-under: TianoCore Contribution Agreement 1.0

+Signed-off-by: Contributor Name <contributor@email.server>

+=== End of sample change description / commit message ===

+

+========================================

+= TianoCore Contribution Agreement 1.0 =

+========================================

+

+INTEL CORPORATION ("INTEL") MAKES AVAILABLE SOFTWARE, DOCUMENTATION,

+INFORMATION AND/OR OTHER MATERIALS FOR USE IN THE TIANOCORE OPEN SOURCE

+PROJECT (COLLECTIVELY "CONTENT"). USE OF THE CONTENT IS GOVERNED BY THE

+TERMS AND CONDITIONS OF THIS AGREEMENT BETWEEN YOU AND INTEL AND/OR THE

+TERMS AND CONDITIONS OF LICENSE AGREEMENTS OR NOTICES INDICATED OR

+REFERENCED BELOW. BY USING THE CONTENT, YOU AGREE THAT YOUR USE OF THE

+CONTENT IS GOVERNED BY THIS AGREEMENT AND/OR THE TERMS AND CONDITIONS

+OF ANY APPLICABLE LICENSE AGREEMENTS OR NOTICES INDICATED OR REFERENCED

+BELOW. IF YOU DO NOT AGREE TO THE TERMS AND CONDITIONS OF THIS

+AGREEMENT AND THE TERMS AND CONDITIONS OF ANY APPLICABLE LICENSE

+AGREEMENTS OR NOTICES INDICATED OR REFERENCED BELOW, THEN YOU MAY NOT

+USE THE CONTENT.

+

+Unless otherwise indicated, all Content made available on the TianoCore

+site is provided to you under the terms and conditions of the BSD

+License ("BSD"). A copy of the BSD License is available at

+http://opensource.org/licenses/bsd-license.php

+or when applicable, in the associated License.txt file.

+

+Certain other content may be made available under other licenses as

+indicated in or with such Content. (For example, in a License.txt file.)

+

+You accept and agree to the following terms and conditions for Your

+present and future Contributions submitted to TianoCore site. Except

+for the license granted to Intel hereunder, You reserve all right,

+title, and interest in and to Your Contributions.

+

+== SECTION 1: Definitions ==

+* "You" or "Contributor" shall mean the copyright owner or legal

+  entity authorized by the copyright owner that is making a

+  Contribution hereunder. All other entities that control, are

+  controlled by, or are under common control with that entity are

+  considered to be a single Contributor. For the purposes of this

+  definition, "control" means (i) the power, direct or indirect, to

+  cause the direction or management of such entity, whether by

+  contract or otherwise, or (ii) ownership of fifty percent (50%)

+  or more of the outstanding shares, or (iii) beneficial ownership

+  of such entity.

+* "Contribution" shall mean any original work of authorship,

+  including any modifications or additions to an existing work,

+  that is intentionally submitted by You to the TinaoCore site for

+  inclusion in, or documentation of, any of the Content. For the

+  purposes of this definition, "submitted" means any form of

+  electronic, verbal, or written communication sent to the

+  TianoCore site or its representatives, including but not limited

+  to communication on electronic mailing lists, source code

+  control systems, and issue tracking systems that are managed by,

+  or on behalf of, the TianoCore site for the purpose of

+  discussing and improving the Content, but excluding

+  communication that is conspicuously marked or otherwise

+  designated in writing by You as "Not a Contribution."

+

+== SECTION 2: License for Contributions ==

+* Contributor hereby agrees that redistribution and use of the

+  Contribution in source and binary forms, with or without

+  modification, are permitted provided that the following

+  conditions are met:

+** Redistributions of source code must retain the Contributor's

+   copyright notice, this list of conditions and the following

+   disclaimer.

+** Redistributions in binary form must reproduce the Contributor's

+   copyright notice, this list of conditions and the following

+   disclaimer in the documentation and/or other materials provided

+   with the distribution.

+* Disclaimer. None of the names of Contributor, Intel, or the names

+  of their respective contributors may be used to endorse or

+  promote products derived from this software without specific

+  prior written permission.

+* Contributor grants a license (with the right to sublicense) under

+  claims of Contributor's patents that Contributor can license that

+  are infringed by the Contribution (as delivered by Contributor) to

+  make, use, distribute, sell, offer for sale, and import the

+  Contribution and derivative works thereof solely to the minimum

+  extent necessary for licensee to exercise the granted copyright

+  license; this patent license applies solely to those portions of

+  the Contribution that are unmodified. No hardware per se is

+  licensed.

+* EXCEPT AS EXPRESSLY SET FORTH IN SECTION 3 BELOW, THE

+  CONTRIBUTION IS PROVIDED BY THE CONTRIBUTOR "AS IS" AND ANY

+  EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,

+  THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A

+  PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE

+  CONTRIBUTOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,

+  SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT

+  NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;

+  LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)

+  HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN

+  CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR

+  OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THE

+  CONTRIBUTION, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH

+  DAMAGE.

+

+== SECTION 3: Representations ==

+* You represent that You are legally entitled to grant the above

+  license. If your employer(s) has rights to intellectual property

+  that You create that includes Your Contributions, You represent

+  that You have received permission to make Contributions on behalf

+  of that employer, that Your employer has waived such rights for

+  Your Contributions.

+* You represent that each of Your Contributions is Your original

+  creation (see Section 4 for submissions on behalf of others).

+  You represent that Your Contribution submissions include complete

+  details of any third-party license or other restriction

+  (including, but not limited to, related patents and trademarks)

+  of which You are personally aware and which are associated with

+  any part of Your Contributions.

+

+== SECTION 4: Third Party Contributions ==

+* Should You wish to submit work that is not Your original creation,

+  You may submit it to TianoCore site separately from any

+  Contribution, identifying the complete details of its source

+  and of any license or other restriction (including, but not

+  limited to, related patents, trademarks, and license agreements)

+  of which You are personally aware, and conspicuously marking the

+  work as "Submitted on behalf of a third-party: [named here]".

+

+== SECTION 5: Miscellaneous ==

+* Applicable Laws. Any claims arising under or relating to this

+  Agreement shall be governed by the internal substantive laws of

+  the State of Delaware or federal courts located in Delaware,

+  without regard to principles of conflict of laws.

+* Language. This Agreement is in the English language only, which

+  language shall be controlling in all respects, and all versions

+  of this Agreement in any other language shall be for accommodation

+  only and shall not be binding. All communications and notices made

+  or given pursuant to this Agreement, and all documentation and

+  support to be provided, unless otherwise noted, shall be in the

+  English language.

+

diff --git a/BaseTools/License.txt b/BaseTools/License.txt
new file mode 100644
index 0000000000..160be01d2a
--- /dev/null
+++ b/BaseTools/License.txt
@@ -0,0 +1,25 @@
+Copyright (c) 2013, Intel Corporation. All rights reserved.

+

+Redistribution and use in source and binary forms, with or without

+modification, are permitted provided that the following conditions

+are met:

+

+* Redistributions of source code must retain the above copyright

+  notice, this list of conditions and the following disclaimer.

+* Redistributions in binary form must reproduce the above copyright

+  notice, this list of conditions and the following disclaimer in

+  the documentation and/or other materials provided with the

+  distribution.

+

+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS

+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT

+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS

+FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE

+COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,

+INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,

+BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;

+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER

+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT

+LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN

+ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE

+POSSIBILITY OF SUCH DAMAGE.

diff --git a/BaseTools/Source/C/GenBootSector/GenBootSector.c b/BaseTools/Source/C/GenBootSector/GenBootSector.c
index 169d81e031..f102ee139a 100644
--- a/BaseTools/Source/C/GenBootSector/GenBootSector.c
+++ b/BaseTools/Source/C/GenBootSector/GenBootSector.c
@@ -1,6 +1,6 @@
 /** @file

 

-Copyright (c) 2006 - 2010, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>

 This program and the accompanying materials                          

 are licensed and made available under the terms and conditions of the BSD License         

 which accompanies this distribution.  The full text of the license may be found at        

@@ -542,8 +542,7 @@ Returns:
 

 --*/

 {

-  printf ("%s v%d.%d %s -Utility to retrieve and update the boot sector or MBR.\n", UTILITY_NAME, UTILITY_MAJOR_VERSION, UTILITY_MINOR_VERSION, __BUILD_VERSION);

-  printf ("Copyright (c) 2009 - 2010 Intel Corporation. All rights reserved.\n");

+  printf ("%s Version %d.%d Build%s\n", UTILITY_NAME, UTILITY_MAJOR_VERSION, UTILITY_MINOR_VERSION, __BUILD_VERSION);

 }

 

 VOID

@@ -551,18 +550,27 @@ PrintUsage (
   void

   )

 {

-  Version();

-  printf ("\nUsage: \n\

-   GenBootSector\n\

-     [-l, --list list disks]\n\

-     [-i, --input Filename]\n\

-     [-o, --output Filename]\n\

-     [-m, --mbr process the MBR also]\n\

-     [-v, --verbose]\n\

-     [--version]\n\

-     [-q, --quiet disable all messages except fatal errors]\n\

-     [-d, --debug[#]\n\

-     [-h, --help]\n");

+  printf ("Usage: GenBootSector [options] --cfg-file CFG_FILE\n\n\

+Copyright (c) 2009 - 2013, Intel Corporation.  All rights reserved.\n\n\

+  Utility to retrieve and update the boot sector or MBR.\n\n\

+optional arguments:\n\

+  -h, --help            Show this help message and exit\n\

+  --version             Show program's version number and exit\n\

+  -d [DEBUG], --debug [DEBUG]\n\

+                        Output DEBUG statements, where DEBUG_LEVEL is 0 (min)\n\

+                        - 9 (max)\n\

+  -v, --verbose         Print informational statements\n\

+  -q, --quiet           Returns the exit code, error messages will be\n\

+                        displayed\n\

+  -s, --silent          Returns only the exit code; informational and error\n\

+                        messages are not displayed\n\

+  -l, --list            List disk drives\n\

+  -i INPUT_FILENAME, --input INPUT_FILENAME\n\

+                        Input file name\n\

+  -o OUTPUT_FILENAME, --output OUTPUT_FILENAME\n\

+                        Output file name\n\

+  -m, --mbr             Also process the MBR\n\

+  --sfo                 Reserved for future use\n");

 

 }

 

diff --git a/BaseTools/Source/C/GenCrc32/GenCrc32.c b/BaseTools/Source/C/GenCrc32/GenCrc32.c
index 681fe4f1e6..8ece9a8412 100644
--- a/BaseTools/Source/C/GenCrc32/GenCrc32.c
+++ b/BaseTools/Source/C/GenCrc32/GenCrc32.c
@@ -1,6 +1,6 @@
 /** @file

 

-Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2007 - 2013, Intel Corporation. All rights reserved.<BR>

 This program and the accompanying materials                          

 are licensed and made available under the terms and conditions of the BSD License         

 which accompanies this distribution.  The full text of the license may be found at        

@@ -55,7 +55,7 @@ Returns:
 

 --*/

 {

-  fprintf (stdout, "%s Version %d.%d %s \n", UTILITY_NAME, UTILITY_MAJOR_VERSION, UTILITY_MINOR_VERSION, __BUILD_VERSION);

+  fprintf (stdout, "%s Version %d.%d Build %s \n", UTILITY_NAME, UTILITY_MAJOR_VERSION, UTILITY_MINOR_VERSION, __BUILD_VERSION);

 }

 

 VOID

@@ -81,26 +81,32 @@ Returns:
   //

   // Summary usage

   //

-  fprintf (stdout, "\nUsage: %s -e|-d [options] <input_file>\n\n", UTILITY_NAME);

+  fprintf (stdout, "Usage: GenCrc32 -e|-d [options] <input_file>\n\n");

   

   //

   // Copyright declaration

   // 

-  fprintf (stdout, "Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.\n\n");

+  fprintf (stdout, "Copyright (c) 2007 - 2013, Intel Corporation. All rights reserved.\n\n");

 

   //

   // Details Option

   //

-  fprintf (stdout, "Options:\n");

-  fprintf (stdout, "  -o FileName, --output FileName\n\

-                        File will be created to store the ouput content.\n");

-  fprintf (stdout, "  -e, --encode          Calculate CRC32 value for the input file.\n");

-  fprintf (stdout, "  -d, --decode          Verify CRC32 value for the input file.\n");

-  fprintf (stdout, "  -v, --verbose         Turn on verbose output with informational messages.\n");

-  fprintf (stdout, "  -q, --quiet           Disable all messages except key message and fatal error\n");

-  fprintf (stdout, "  --debug level         Enable debug messages, at input debug level.\n");

-  fprintf (stdout, "  --version             Show program's version number and exit.\n");

-  fprintf (stdout, "  -h, --help            Show this help message and exit.\n"); 

+  fprintf (stdout, "optional arguments:\n");

+  fprintf (stdout, "  -h, --help            Show this help message and exit\n");

+  fprintf (stdout, "  --version             Show program's version number and exit\n");

+  fprintf (stdout, "  --debug [DEBUG]       Output DEBUG statements, where DEBUG_LEVEL is 0 (min)\n\

+                        - 9 (max)\n");

+  fprintf (stdout, "  -v, --verbose         Print informational statements\n");

+  fprintf (stdout, "  -q, --quiet           Returns the exit code, error messages will be\n\

+                        displayed\n");

+  fprintf (stdout, "  -s, --silent          Returns only the exit code; informational and error\n\

+                        messages are not displayed\n");

+  fprintf (stdout, "  -e, --encode          Calculate CRC32 value for the input file\n");

+  fprintf (stdout, "  -d, --decode          Verify CRC32 value for the input file\n");

+  fprintf (stdout, "  -o OUTPUT_FILENAME, --output OUTPUT_FILENAME\n\

+                        Output file name\n");

+  fprintf (stdout, "  --sfo                 Reserved for future use\n");

+  

 }

 

 int

@@ -164,7 +170,6 @@ Returns:
   argv ++;

 

   if ((stricmp (argv[0], "-h") == 0) || (stricmp (argv[0], "--help") == 0)) {

-    Version ();

     Usage ();

     return STATUS_SUCCESS;    

   }

diff --git a/BaseTools/Source/C/GenPage/GenPage.c b/BaseTools/Source/C/GenPage/GenPage.c
index 6c24a2f9ec..78047ba9be 100644
--- a/BaseTools/Source/C/GenPage/GenPage.c
+++ b/BaseTools/Source/C/GenPage/GenPage.c
@@ -1,6 +1,6 @@
 /** @file

 

-Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>

+Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>

 This program and the accompanying materials                          

 are licensed and made available under the terms and conditions of the BSD License         

 which accompanies this distribution.  The full text of the license may be found at        

@@ -91,8 +91,7 @@ Returns:
 

 --*/

 {

-  printf ("%s v%d.%d %s -Utility to generate the EfiLoader image containing page table.\n", UTILITY_NAME, UTILITY_MAJOR_VERSION, UTILITY_MINOR_VERSION, __BUILD_VERSION);

-  printf ("Copyright (c) 2008 - 2011 Intel Corporation. All rights reserved.\n");

+  printf ("%s Version %d.%d Build %s\n", UTILITY_NAME, UTILITY_MAJOR_VERSION, UTILITY_MINOR_VERSION, __BUILD_VERSION);

 }

 

 VOID

@@ -100,25 +99,29 @@ Usage (
   void

   )

 {

-  Version();

-  printf ("\nUsage: \n\

-   GenPage\n\

-     -o, --output Filename\n\

-                        The file that contains both non-page table part and\n\

-                        page table\n\

-     [-b, --baseaddr baseaddress]\n\

+  printf ("Usage: GenPage.exe [options] EfiLoaderImageName \n\n\

+Copyright (c) 2008 - 2013, Intel Corporation.  All rights reserved.\n\n\

+  Utility to generate the EfiLoader image containing a page table.\n\n\

+optional arguments:\n\

+  -h, --help            Show this help message and exit\n\

+  --version             Show program's version number and exit\n\

+  -d [DEBUG], --debug [DEBUG]\n\

+                        Output DEBUG statements, where DEBUG_LEVEL is 0 (min)\n\

+                        - 9 (max)\n\

+  -v, --verbose         Print informational statements\n\

+  -q, --quiet           Returns the exit code, error messages will be\n\

+                        displayed\n\

+  -s, --silent          Returns only the exit code; informational and error\n\

+                        messages are not displayed\n\

+  -o OUTPUT_FILENAME, --output OUTPUT_FILENAME\n\

+                        Output file contain both the non-page table part and\n\

+                        the page table\n\

+  -b BASE_ADDRESS, --baseaddr BASE_ADDRESS\n\

                         The page table location\n\

-     [-f, --offset offset]\n\

+  -f OFFSET, --offset OFFSET\n\

                         The position that the page table will appear in the\n\

                         output file\n\

-     [-v, --verbose]    Turn on verbose output with informational messages\n\

-                        printed\n\

-     [--version]        Print version and copyright of this program and exit\n\

-     [-q, --quiet]      Disable all messages except unrecoverable errors\n\

-     [-d, --debug[#]]   Enable debug messages, at level #\n\

-     [-h, --help]       Print copyright, version and usage of this program\n\

-                        and exit\n\

-     EfiLoaderImageName\n");

+  --sfo                 Reserved for future use\n");

 

 }

 

diff --git a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
index 8985ddefca..7cadf0f42b 100644
--- a/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
+++ b/BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp
@@ -803,6 +803,7 @@ CFormPkg::DeclarePendingQuestion (
   CHAR8          FName[MAX_NAME_LEN];

   CHAR8          *SName;

   CHAR8          *NewStr;

+  UINT32         ShrinkSize;

   EFI_VFR_RETURN_CODE  ReturnCode;

   EFI_VFR_VARSTORE_TYPE VarStoreType  = EFI_VFR_VARSTORE_INVALID;

   EFI_VARSTORE_ID       VarStoreId    = EFI_VARSTORE_ID_INVALID;

@@ -823,7 +824,7 @@ CFormPkg::DeclarePendingQuestion (
     if (pNode->mFlag == PENDING) {

       CIfrNumeric CNObj;

       EFI_VARSTORE_INFO Info; 

-  	  EFI_QUESTION_ID   QId   = EFI_QUESTION_ID_INVALID;

+      EFI_QUESTION_ID   QId   = EFI_QUESTION_ID_INVALID;

 

       CNObj.SetLineNo (LineNo);

       CNObj.SetPrompt (0x0);

@@ -913,19 +914,24 @@ CFormPkg::DeclarePendingQuestion (
       switch (Info.mVarType) {

       case EFI_IFR_TYPE_NUM_SIZE_64:

         CNObj.SetMinMaxStepData ((UINT64) 0, (UINT64) -1 , (UINT64) 0);

+        ShrinkSize = 0;

         break;

       case EFI_IFR_TYPE_NUM_SIZE_32:

         CNObj.SetMinMaxStepData ((UINT32) 0, (UINT32) -1 , (UINT32) 0);

+        ShrinkSize = 12;

         break;

       case EFI_IFR_TYPE_NUM_SIZE_16:

         CNObj.SetMinMaxStepData ((UINT16) 0, (UINT16) -1 , (UINT16) 0);

+        ShrinkSize = 18;

         break;

       case EFI_IFR_TYPE_NUM_SIZE_8:

         CNObj.SetMinMaxStepData ((UINT8) 0, (UINT8) -1 , (UINT8) 0);

+        ShrinkSize = 21;

         break;

       default:

         break;

       }

+      CNObj.ShrinkBinSize (ShrinkSize);

 

       //

       // For undefined Efi VarStore type question

@@ -935,7 +941,7 @@ CFormPkg::DeclarePendingQuestion (
         CIfrVarEqName CVNObj (QId, Info.mInfo.mVarName);

         CVNObj.SetLineNo (LineNo);

       }

-      

+

       //

       // End for Numeric

       //

@@ -1236,6 +1242,18 @@ CIfrRecordInfoDB::GetRecordInfoFromOffset (
   return pNode;

 }

 

+/*

+  Add just the op code position.

+

+  From

+  

+  | form end opcode + end of if opcode for form ... + Dynamic opcode + form set end opcode |

+  

+  To

+  

+  | Dynamic opcode + form end opcode + end of if opcode for form ... + form set end opcode |

+

+*/

 BOOLEAN

 CIfrRecordInfoDB::IfrAdjustDynamicOpcodeInRecords (

   VOID

diff --git a/BaseTools/Source/C/VfrCompile/VfrSyntax.g b/BaseTools/Source/C/VfrCompile/VfrSyntax.g
index e6e69bca0e..65f0421ccf 100644
--- a/BaseTools/Source/C/VfrCompile/VfrSyntax.g
+++ b/BaseTools/Source/C/VfrCompile/VfrSyntax.g
@@ -604,6 +604,10 @@ vfrFormSetDefinition :
 

                                                       CRT_END_OP (E);

 

+                                                      //

+                                                      // Adjust the pending question position.

+                                                      // Move the position from current to before the end of the last form in the form set.

+                                                      //

                                                       if (gNeedAdjustOpcode) {

                                                         gCFormPkg.AdjustDynamicInsertOpcode (

                                                           mLastFormEndAddr,