From 9c06b955e056504f723d8828a956fe6303f8135a Mon Sep 17 00:00:00 2001 From: Thomas Preud'homme Date: Thu, 10 Oct 2019 10:29:01 +0000 Subject: [LNT] Python 3 support: remove useless var-setting getter Both the ComparisonResult constructor and the stddev_mean getter set the readonly stddev_mean. While Python 2 accepts it, Python 3 throws errors (cannot set attribute and infinite recursion respectively). Since that attribute does not appear to be used anywhere, this commit removes all this code. Reviewers: cmatthews, hubert.reinterpretcast, kristof.beyls Reviewed By: hubert.reinterpretcast Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D67882 git-svn-id: https://llvm.org/svn/llvm-project/lnt/trunk@374302 91177308-0d34-0410-b5e6-96231b3b80d8 --- lnt/server/reporting/analysis.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/lnt/server/reporting/analysis.py b/lnt/server/reporting/analysis.py index 4929936..df4ed86 100644 --- a/lnt/server/reporting/analysis.py +++ b/lnt/server/reporting/analysis.py @@ -96,7 +96,6 @@ class ComparisonResult: self.stddev = None self.MAD = None - self.stddev_mean = None # Only calculate this if needed. self.failed = cur_failed self.prev_failed = prev_failed self.samples = samples @@ -105,14 +104,6 @@ class ComparisonResult: self.confidence_lv = confidence_lv self.bigger_is_better = bigger_is_better - @property - def stddev_mean(self): - """The mean around stddev for current sampples. Cached after first call. - """ - if not self.stddev_mean: - self.stddev_mean = stats.mean(self.samples) - return self.stddev_mean - def __repr__(self): """Print this ComparisonResult's constructor. -- cgit v1.2.3