summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEd Schouten <ed@nuxi.nl>2017-03-09 08:04:07 +0000
committerEd Schouten <ed@nuxi.nl>2017-03-09 08:04:07 +0000
commit188f3c7c17139dfb77518a1b52dfa482d9e1ced2 (patch)
treea518cb868230aa174bf43dbccfe9d836ef01e570
parent2fd2d585a530d0564a5ef4b1184e0767c84c93b0 (diff)
Fix up the places where AddressSpace.hpp is included.
The AddressSpace.hpp header declares two classes: LocalAddressSpace and RemoteAddressSpace. These classes are only used in a very small number of source files, but passed in as template arguments to many other classes. Let's go ahead and only include AddressSpace.hpp in source files where at least one of these two classes is mentioned. This gets rid of a cyclic header dependency that was already present, but only caused breakage on macOS until recently. Reported by: Marshall Clow git-svn-id: https://llvm.org/svn/llvm-project/libunwind/trunk@297364 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--src/CompactUnwinder.hpp1
-rw-r--r--src/DwarfInstructions.hpp1
-rw-r--r--src/DwarfParser.hpp1
-rw-r--r--src/EHHeaderParser.hpp1
-rw-r--r--src/Unwind_AppleExtras.cpp1
-rw-r--r--src/libunwind.cpp1
6 files changed, 2 insertions, 4 deletions
diff --git a/src/CompactUnwinder.hpp b/src/CompactUnwinder.hpp
index 1be1b0b..7b97bf8 100644
--- a/src/CompactUnwinder.hpp
+++ b/src/CompactUnwinder.hpp
@@ -19,7 +19,6 @@
#include <libunwind.h>
#include <mach-o/compact_unwind_encoding.h>
-#include "AddressSpace.hpp"
#include "Registers.hpp"
#define EXTRACT_BITS(value, mask) \
diff --git a/src/DwarfInstructions.hpp b/src/DwarfInstructions.hpp
index f3a4d2c..a428633 100644
--- a/src/DwarfInstructions.hpp
+++ b/src/DwarfInstructions.hpp
@@ -18,7 +18,6 @@
#include <stdlib.h>
#include "dwarf2.h"
-#include "AddressSpace.hpp"
#include "Registers.hpp"
#include "DwarfParser.hpp"
#include "config.h"
diff --git a/src/DwarfParser.hpp b/src/DwarfParser.hpp
index 586653b..81f1658 100644
--- a/src/DwarfParser.hpp
+++ b/src/DwarfParser.hpp
@@ -21,7 +21,6 @@
#include "libunwind.h"
#include "dwarf2.h"
-#include "AddressSpace.hpp"
#include "config.h"
namespace libunwind {
diff --git a/src/EHHeaderParser.hpp b/src/EHHeaderParser.hpp
index 6c3ccc8..c66af21 100644
--- a/src/EHHeaderParser.hpp
+++ b/src/EHHeaderParser.hpp
@@ -15,7 +15,6 @@
#include "libunwind.h"
-#include "AddressSpace.hpp"
#include "DwarfParser.hpp"
namespace libunwind {
diff --git a/src/Unwind_AppleExtras.cpp b/src/Unwind_AppleExtras.cpp
index d8301c0..8015150 100644
--- a/src/Unwind_AppleExtras.cpp
+++ b/src/Unwind_AppleExtras.cpp
@@ -9,6 +9,7 @@
//===----------------------------------------------------------------------===//
#include "config.h"
+#include "AddressSpace.hpp"
#include "DwarfParser.hpp"
#include "unwind_ext.h"
diff --git a/src/libunwind.cpp b/src/libunwind.cpp
index 3133e5a..4971544 100644
--- a/src/libunwind.cpp
+++ b/src/libunwind.cpp
@@ -24,6 +24,7 @@
#include <stdlib.h>
+#include "AddressSpace.hpp"
#include "UnwindCursor.hpp"
using namespace libunwind;