From 08ae890c8b671238528816812388b6b55410a49f Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 7 Oct 2015 15:14:10 +0000 Subject: Loosening the restriction on variadic function definitions so that extern "C" function definitions are permissible. git-svn-id: https://llvm.org/svn/llvm-project/clang-tools-extra/trunk@249555 91177308-0d34-0410-b5e6-96231b3b80d8 --- clang-tidy/cert/VariadicFunctionDefCheck.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'clang-tidy/cert/VariadicFunctionDefCheck.cpp') diff --git a/clang-tidy/cert/VariadicFunctionDefCheck.cpp b/clang-tidy/cert/VariadicFunctionDefCheck.cpp index ac788a3a..a5f8fa7e 100644 --- a/clang-tidy/cert/VariadicFunctionDefCheck.cpp +++ b/clang-tidy/cert/VariadicFunctionDefCheck.cpp @@ -20,9 +20,12 @@ void VariadicFunctionDefCheck::registerMatchers(MatchFinder *Finder) { if (!getLangOpts().CPlusPlus) return; - // We only care about function *definitions* that are variadic. - Finder->addMatcher(functionDecl(isDefinition(), isVariadic()).bind("func"), - this); + // We only care about function *definitions* that are variadic, and do not + // have extern "C" language linkage. + Finder->addMatcher( + functionDecl(isDefinition(), isVariadic(), unless(isExternC())) + .bind("func"), + this); } void VariadicFunctionDefCheck::check(const MatchFinder::MatchResult &Result) { -- cgit v1.2.3