From 0890b981c9051f9b94d9a481dcf5bfd0d80d2313 Mon Sep 17 00:00:00 2001 From: Andrew Pinski Date: Tue, 12 Dec 2006 22:33:06 +0000 Subject: re PR middle-end/28436 (accessing an element via a "pointer" on a vector does not cause vec_extract to be used) 2006-12-12 Andrew Pinski PR tree-opt/28436 * tree.h (DECL_COMPLEX_GIMPLE_REG_P): Rename to ... (DECL_GIMPLE_REG_P): This. * fold-const.c (fold_indirect_ref_1): Fold *(foo *)&vectorfoo into using BIT_FIELD_REF. * omp-low.c (omp_copy_decl_2): Use the renamed DECL_GIMPLE_REG_P. * tree-gimple.c (is_gimple_reg): Use the renamed DECL_GIMPLE_REG_P and check for VECTOR_TYPE. * expr.c (get_inner_reference): Set the mode for BIT_FIELD_REF with vector types. * tree-flow-inline.h (var_can_have_subvars): Use the renamed DECL_GIMPLE_REG_P. * gimplify.c (internal_get_tmp_var): Use the renamed DECL_GIMPLE_REG_P and check for VECTOR_TYPE. (gimplify_bind_expr): Likewise. (gimplify_function_tree): Likewise. * expmed.c: Include target.h. (extract_bit_field): For vector mode, try find a better mode first. If that fails use gen_lowpart (for vectors only). * tree-dfa.c (make_rename_temp): Use the renamed DECL_GIMPLE_REG_P and check for VECTOR_TYPE. * tree-ssa-pre.c (create_expressions_by_pieces): Likewise. (insert_into_preds_of_block): Likewise. (insert_fake_stores): Create gimple register store_tmps for vector types. * tree-sra.c (sra_elt): New field, is_vector_lhs. (sra_walk_expr ): For vector types that are the left hand side, set the element's is_vector_lhs to true. (instantiate_element): For vector types which were on the left hand size, set DECL_GIMPLE_REG_P to false. * tree-nested.c (create_tmp_var_for): Use the renamed DECL_GIMPLE_REG_P. * tree-inline.c (declare_return_variable): Use the renamed DECL_GIMPLE_REG_P and check for VECTOR_TYPE. (copy_decl_to_var): Use the renamed DECL_GIMPLE_REG_P. (copy_result_decl_to_var): Likewise. * tree-vect-transform.c (vect_get_new_vect_var): For vector types, create a gimple register variable. (vect_permute_store_chain): Set DECL_GIMPLE_REG_P to true for the vect_inter_* temp variables. * Makefile.in (expmed.o): Update dependencies. 2006-12-12 Andrew Pinski PR tree-opt/28436 * gcc.c-torture/compile/vector-1.c: New test. * gcc.c-torture/compile/vector-2.c: New test. * gcc.c-torture/compile/vector-3.c: New test. From-SVN: r119801 --- gcc/tree-sra.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'gcc/tree-sra.c') diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c index 14507ad3adf..da338fc28fd 100644 --- a/gcc/tree-sra.c +++ b/gcc/tree-sra.c @@ -140,6 +140,9 @@ struct sra_elt /* A flag for use with/after random access traversals. */ bool visited; + + /* True if there is BIT_FIELD_REF on the lhs with a vector. */ + bool is_vector_lhs; }; #define IS_ELEMENT_FOR_GROUP(ELEMENT) (TREE_CODE (ELEMENT) == RANGE_EXPR) @@ -787,9 +790,18 @@ sra_walk_expr (tree *expr_p, block_stmt_iterator *bsi, bool is_output, break; case BIT_FIELD_REF: + /* A bit field reference to a specific vector is scalarized but for + ones for inputs need to be marked as used on the left hand size so + when we scalarize it, we can mark that variable as non renamable. */ + if (is_output && TREE_CODE (TREE_TYPE (TREE_OPERAND (inner, 0))) == VECTOR_TYPE) + { + struct sra_elt *elt = maybe_lookup_element_for_expr (TREE_OPERAND (inner, 0)); + elt->is_vector_lhs = true; + } /* A bit field reference (access to *multiple* fields simultaneously) is not currently scalarized. Consider this an access to the complete outer element, to which walk_tree will bring us next. */ + goto use_all; case VIEW_CONVERT_EXPR: @@ -1178,6 +1190,12 @@ instantiate_element (struct sra_elt *elt) base = base_elt->element; elt->replacement = var = make_rename_temp (elt->type, "SR"); + + /* For vectors, if used on the left hand side with BIT_FIELD_REF, + they are not a gimple register. */ + if (TREE_CODE (TREE_TYPE (var)) == VECTOR_TYPE && elt->is_vector_lhs) + DECL_GIMPLE_REG_P (var) = 0; + DECL_SOURCE_LOCATION (var) = DECL_SOURCE_LOCATION (base); DECL_ARTIFICIAL (var) = 1; -- cgit v1.2.3