diff options
| author | Frederik Harwath <frederik@codesourcery.com> | 2020-02-13 07:30:16 +0100 |
|---|---|---|
| committer | Frederik Harwath <frederik@codesourcery.com> | 2020-02-13 10:18:31 +0100 |
| commit | 001ab12e620c6f117b2e93c77d188bd62fe7ba03 (patch) | |
| tree | 5959fb334ce14c7aae95607ecf538d41a8d1db5a /libgomp/plugin | |
| parent | 8aba425f4ebc5e2c054776d3cdddf13f7c1918f8 (diff) | |
openmp: ignore nowait if async execution is unsupported [PR93481]
An OpenMP "nowait" clause on a target construct currently leads to
a call to GOMP_OFFLOAD_async_run in the plugin that is used for
offloading at execution time. The nvptx plugin contains only a stub
of this function that always produces a fatal error if called.
This commit changes the "nowait" implementation to ignore the clause
if the executing device's plugin does not implement GOMP_OFFLOAD_async_run.
The stub in the nvptx plugin is removed which effectively means that
programs containing "nowait" can now be executed with nvptx offloading
as if the clause had not been used.
This behavior is consistent with the OpenMP specification which says that
"[...] execution of the target task *may* be deferred" (emphasis added),
cf. OpenMP 5.0, page 172.
libgomp/
* plugin/plugin-nvptx.c: Remove GOMP_OFFLOAD_async_run stub.
* target.c (gomp_load_plugin_for_device): Make "async_run" loading
optional.
(gomp_target_task_fn): Assert "devicep->async_run_func".
(clear_unsupported_flags): New function to remove unsupported flags
(right now only GOMP_TARGET_FLAG_NOWAIT) that can be be ignored.
(GOMP_target_ext): Apply clear_unsupported_flags to flags.
* testsuite/libgomp.c/target-33.c:
Remove xfail for offload_target_nvptx.
* testsuite/libgomp.c/target-34.c: Likewise.
Diffstat (limited to 'libgomp/plugin')
| -rw-r--r-- | libgomp/plugin/plugin-nvptx.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/libgomp/plugin/plugin-nvptx.c b/libgomp/plugin/plugin-nvptx.c index 6033c71a9db..ec103a2f40b 100644 --- a/libgomp/plugin/plugin-nvptx.c +++ b/libgomp/plugin/plugin-nvptx.c @@ -1931,9 +1931,4 @@ GOMP_OFFLOAD_run (int ord, void *tgt_fn, void *tgt_vars, void **args) nvptx_stacks_free (stacks, teams * threads); } -void -GOMP_OFFLOAD_async_run (int ord, void *tgt_fn, void *tgt_vars, void **args, - void *async_data) -{ - GOMP_PLUGIN_fatal ("GOMP_OFFLOAD_async_run unimplemented"); -} +/* TODO: Implement GOMP_OFFLOAD_async_run. */ |