aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Brobecker <brobecker@adacore.com>2022-03-11 03:39:53 +0000
committerPierre-Marie de Rodat <derodat@adacore.com>2022-05-16 08:42:05 +0000
commit1bdf9fa390282299418e21534674d0ab252e9f34 (patch)
tree02ff1961a5bac943712a12ac88dd423e8766b565
parent839e7f16abda3fd8bd46d59ff1521d402d328a24 (diff)
[Ada] sigaction result not properly checked in __gnat_install_handler (QNX)
The QNX version of __gnat_install_handler calls sigaction for a number of signals, and then prints an error message when the the call failed. But unfortunately, except for the first call, we forgot to store sigaction's return value, so the check that ensues uses a potentially uninitialized variable, which the compiler does detect (this is how we found this issue). This change fixes this by make sure we store the result of each sigaction call before checking it. While at it, we noticed a thinko in the error messages all alerting about the SIGFPE signal, rather than the signal it just tested. Most likely a copy/paste thinko. Fixed by this change as well. gcc/ada/ * init.c (__gnat_install_handler) [__QNX__]: Save sigaction's return value in err before checking err's value. Fix incorrect signal names in perror messages.
-rw-r--r--gcc/ada/init.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/gcc/ada/init.c b/gcc/ada/init.c
index 4615cc152b2..89f16a176d3 100644
--- a/gcc/ada/init.c
+++ b/gcc/ada/init.c
@@ -2625,26 +2625,26 @@ __gnat_install_handler (void)
}
}
if (__gnat_get_interrupt_state (SIGILL) != 's') {
- sigaction (SIGILL, &act, NULL);
+ err = sigaction (SIGILL, &act, NULL);
if (err == -1) {
err = errno;
- perror ("error while attaching SIGFPE");
+ perror ("error while attaching SIGILL");
perror (strerror (err));
}
}
if (__gnat_get_interrupt_state (SIGSEGV) != 's') {
- sigaction (SIGSEGV, &act, NULL);
+ err = sigaction (SIGSEGV, &act, NULL);
if (err == -1) {
err = errno;
- perror ("error while attaching SIGFPE");
+ perror ("error while attaching SIGSEGV");
perror (strerror (err));
}
}
if (__gnat_get_interrupt_state (SIGBUS) != 's') {
- sigaction (SIGBUS, &act, NULL);
+ err = sigaction (SIGBUS, &act, NULL);
if (err == -1) {
err = errno;
- perror ("error while attaching SIGFPE");
+ perror ("error while attaching SIGBUS");
perror (strerror (err));
}
}