aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVitaly Buka <vitalybuka@google.com>2022-08-03 15:04:26 -0700
committerVitaly Buka <vitalybuka@google.com>2022-08-05 13:42:17 -0700
commit8d2901d53708b72ae3cb56ac78d3cd0e591db669 (patch)
tree77a57e44e2d75f6315ea59ce202d7a0ffd078875
parentb5244fb71caedc65900f54f83f0acc786a0464ae (diff)
[NFC][Inliner] Add Load/Store handler
This is an additional signal which may benefit sanitizers. Reviewed By: kda Differential Revision: https://reviews.llvm.org/D131129
-rw-r--r--llvm/lib/Analysis/InlineCost.cpp13
1 files changed, 13 insertions, 0 deletions
diff --git a/llvm/lib/Analysis/InlineCost.cpp b/llvm/lib/Analysis/InlineCost.cpp
index 4f7b342d9f1a..ebb1f20641bd 100644
--- a/llvm/lib/Analysis/InlineCost.cpp
+++ b/llvm/lib/Analysis/InlineCost.cpp
@@ -126,6 +126,10 @@ static cl::opt<int>
InstrCost("inline-instr-cost", cl::Hidden, cl::init(5),
cl::desc("Cost of a single instruction when inlining"));
+static cl::opt<int>
+ MemAccessCost("inline-memaccess-cost", cl::Hidden, cl::init(0),
+ cl::desc("Cost of load/store instruction when inlining"));
+
static cl::opt<int> CallPenalty(
"inline-call-penalty", cl::Hidden, cl::init(25),
cl::desc("Call penalty that is applied per callsite when inlining"));
@@ -282,6 +286,9 @@ protected:
/// Called to account for a call.
virtual void onCallPenalty() {}
+ /// Called to account for a load or store.
+ virtual void onMemAccess(){};
+
/// Called to account for the expectation the inlining would result in a load
/// elimination.
virtual void onLoadEliminationOpportunity() {}
@@ -625,6 +632,9 @@ class InlineCostCallAnalyzer final : public CallAnalyzer {
}
void onCallPenalty() override { addCost(CallPenalty); }
+
+ void onMemAccess() override { addCost(MemAccessCost); }
+
void onCallArgumentSetup(const CallBase &Call) override {
// Pay the price of the argument setup. We account for the average 1
// instruction per call argument setup here.
@@ -2044,6 +2054,7 @@ bool CallAnalyzer::visitLoad(LoadInst &I) {
return true;
}
+ onMemAccess();
return false;
}
@@ -2060,6 +2071,8 @@ bool CallAnalyzer::visitStore(StoreInst &I) {
// 2. We should probably at some point thread MemorySSA for the callee into
// this and then use that to actually compute *really* precise savings.
disableLoadElimination();
+
+ onMemAccess();
return false;
}