From 23fedf7e1861745dff6c3b00a6842e8d4f21f5ad Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 4 Jan 2019 07:14:17 +0000 Subject: RangeMap.h: merge RangeDataArray and RangeDataVector Summary: The main difference between the classes was supposed to be the fact that one is backed by llvm::SmallVector, and the other by std::vector. However, over the years, they have accumulated various other differences too. This essentially removes the std::vector version, as that is pretty much identical to llvm::SmallVector, and combines their interfaces. It does not attempt to do a more significant refactoring, even though there is still a lot of duplication in this file, as it is hard to tell which quirk of some API is depended on by somebody (and, a previous, more ambitious attempt at this in D16769 has failed). I also add some tests, including one which demonstrates one of the quirks/bugs of the API I have noticed in the process. Reviewers: clayborg, teemperor, tberghammer Subscribers: mgorny, JDevlieghere, lldb-commits Differential Revision: https://reviews.llvm.org/D56170 --- lldb/source/Plugins/Process/elf-core/ProcessElfCore.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lldb/source/Plugins/Process') diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.h b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.h index 42b1735a760..2c7268662fe 100644 --- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.h +++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.h @@ -136,7 +136,7 @@ private: // For ProcessElfCore only //------------------------------------------------------------------ typedef lldb_private::Range FileRange; - typedef lldb_private::RangeDataArray + typedef lldb_private::RangeDataVector VMRangeToFileOffset; typedef lldb_private::RangeDataVector VMRangeToPermissions; -- cgit v1.2.3