diff options
author | Jason Molenda <jmolenda@apple.com> | 2018-06-11 21:36:40 +0000 |
---|---|---|
committer | Jason Molenda <jmolenda@apple.com> | 2018-06-11 21:36:40 +0000 |
commit | edf1cfcf77ce6f40caf1700f6f111cd7e90c5714 (patch) | |
tree | dde7454f36b5ffe36e2bc606baa820d2a4df0c74 /lldb/source/Plugins/SymbolVendor | |
parent | bd3bb1037de697969d8567d13158123868eea483 (diff) |
Document how lldb uses the DBGSourcePathRemapping
source path remapping src/dest path pairs with
respect to the DBGVersion number in the plist.
Diffstat (limited to 'lldb/source/Plugins/SymbolVendor')
-rw-r--r-- | lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp b/lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp index ec8516b39f6..c69eb7fd51c 100644 --- a/lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp +++ b/lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp @@ -192,16 +192,14 @@ SymbolVendorMacOSX::CreateInstance(const lldb::ModuleSP &module_sp, ->GetValueForKey("DBGSourcePathRemapping") ->GetAsDictionary()) { - // In an early version of DBGSourcePathRemapping, the - // DBGSourcePath values were incorrect. If we have a - // newer style DBGSourcePathRemapping, there will be a - // DBGVersion key in the plist with version 2 or - // higher. + // If DBGVersion 1 or DBGVersion missing, ignore DBGSourcePathRemapping. + // If DBGVersion 2, strip last two components of path remappings from + // entries to fix an issue with a specific set of + // DBGSourcePathRemapping entries that lldb worked + // with. + // If DBGVersion 3, trust & use the source path remappings as-is. // - // If this is an old style DBGSourcePathRemapping, - // ignore the value half of the key-value remappings - // and use reuse the original gloal DBGSourcePath - // string. + bool new_style_source_remapping_dictionary = false; bool do_truncate_remapping_names = false; std::string original_DBGSourcePath_value = |