[clang-tidy] Revert my readability-uppercase-literal-suffix check.

There are some lurking issues with the handling of the SourceManager.
Somehow sometimes we end up extracting completely wrong
portions of the source buffer.

Reverts r344772, r44760, r344758, r344755.

5 files changed, 0 insertions, 81 deletions

diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index 4b1a6f2b7c8..0115a480b3e 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -142,30 +142,12 @@ Improvements to clang-tidy
   Detects usage of magic numbers, numbers that are used as literals instead of
   introduced via constants or symbols.
 
-- New :doc:`readability-uppercase-literal-suffix
-  <clang-tidy/checks/readability-uppercase-literal-suffix>` check.
-
-  Detects when the integral literal or floating point literal has non-uppercase
-  suffix, and suggests to make the suffix uppercase. The list of destination
-  suffixes can be optionally provided.
-
-- New alias :doc:`cert-dcl16-c
-  <clang-tidy/checks/cert-dcl16-c>` to :doc:`readability-uppercase-literal-suffix
-  <clang-tidy/checks/readability-uppercase-literal-suffix>`
-  added.
-
 - New alias :doc:`cppcoreguidelines-non-private-member-variables-in-classes
   <clang-tidy/checks/cppcoreguidelines-non-private-member-variables-in-classes>`
   to :doc:`misc-non-private-member-variables-in-classes
   <clang-tidy/checks/misc-non-private-member-variables-in-classes>`
   added.
 
-- New alias :doc:`hicpp-uppercase-literal-suffix
-  <clang-tidy/checks/hicpp-uppercase-literal-suffix>` to
-  :doc:`readability-uppercase-literal-suffix
-  <clang-tidy/checks/readability-uppercase-literal-suffix>`
-  added.
-
 - The :doc:`readability-redundant-smartptr-get
   <clang-tidy/checks/readability-redundant-smartptr-get>` check does not warn
   about calls inside macros anymore by default.
diff --git a/clang-tools-extra/docs/clang-tidy/checks/cert-dcl16-c.rst b/clang-tools-extra/docs/clang-tidy/checks/cert-dcl16-c.rst
deleted file mode 100644
index edfe5283c90..00000000000
--- a/clang-tools-extra/docs/clang-tidy/checks/cert-dcl16-c.rst
+++ /dev/null
@@ -1,9 +0,0 @@
-.. title:: clang-tidy - cert-dcl16-c
-.. meta::
-   :http-equiv=refresh: 5;URL=readability-uppercase-literal-suffix.html
-
-cert-dcl16-c
-============
-
-The cert-dcl16-c check is an alias, please see
-`readability-uppercase-literal-suffix <readability-uppercase-literal-suffix.html>`_ for more information.
diff --git a/clang-tools-extra/docs/clang-tidy/checks/hicpp-uppercase-literal-suffix.rst b/clang-tools-extra/docs/clang-tidy/checks/hicpp-uppercase-literal-suffix.rst
deleted file mode 100644
index 88fafd585fa..00000000000
--- a/clang-tools-extra/docs/clang-tidy/checks/hicpp-uppercase-literal-suffix.rst
+++ /dev/null
@@ -1,9 +0,0 @@
-.. title:: clang-tidy - hicpp-uppercase-literal-suffix
-.. meta::
-   :http-equiv=refresh: 5;URL=readability-uppercase-literal-suffix.html
-
-hicpp-uppercase-literal-suffix
-==============================
-
-The hicpp-uppercase-literal-suffix check is an alias, please see
-`readability-uppercase-literal-suffix <readability-uppercase-literal-suffix.html>`_ for more information.
diff --git a/clang-tools-extra/docs/clang-tidy/checks/list.rst b/clang-tools-extra/docs/clang-tidy/checks/list.rst
index a5b5a4f7780..3123797546e 100644
--- a/clang-tools-extra/docs/clang-tidy/checks/list.rst
+++ b/clang-tools-extra/docs/clang-tidy/checks/list.rst
@@ -66,7 +66,6 @@ Clang-Tidy Checks
    bugprone-use-after-move
    bugprone-virtual-near-miss
    cert-dcl03-c (redirects to misc-static-assert) <cert-dcl03-c>
-   cert-dcl16-c (redirects to readability-uppercase-literal-suffix) <cert-dcl16-c>
    cert-dcl21-cpp
    cert-dcl50-cpp
    cert-dcl54-cpp (redirects to misc-new-delete-overloads) <cert-dcl54-cpp>
@@ -159,7 +158,6 @@ Clang-Tidy Checks
    hicpp-use-nullptr (redirects to modernize-use-nullptr) <hicpp-use-nullptr>
    hicpp-use-override (redirects to modernize-use-override) <hicpp-use-override>
    hicpp-vararg (redirects to cppcoreguidelines-pro-type-vararg) <hicpp-vararg>
-   hicpp-uppercase-literal-suffix (redirects to readability-uppercase-literal-suffix) <hicpp-uppercase-literal-suffix>
    llvm-header-guard
    llvm-include-order
    llvm-namespace-comment
@@ -251,5 +249,4 @@ Clang-Tidy Checks
    readability-static-definition-in-anonymous-namespace
    readability-string-compare
    readability-uniqueptr-delete-release
-   readability-uppercase-literal-suffix
    zircon-temporary-objects
diff --git a/clang-tools-extra/docs/clang-tidy/checks/readability-uppercase-literal-suffix.rst b/clang-tools-extra/docs/clang-tidy/checks/readability-uppercase-literal-suffix.rst
deleted file mode 100644
index e869fbee4a2..00000000000
--- a/clang-tools-extra/docs/clang-tidy/checks/readability-uppercase-literal-suffix.rst
+++ /dev/null
@@ -1,42 +0,0 @@
-.. title:: clang-tidy - readability-uppercase-literal-suffix
-
-readability-uppercase-literal-suffix
-====================================
-
-`cert-dcl16-c` redirects here as an alias for this check.
-By default, only the suffixes that begin with 'l' ("l", "ll", "lu", "llu",
-but not "u", "ul", "ull") are diagnosed by that alias.
-
-`hicpp-uppercase-literal-suffix` redirects here as an alias for this check.
-
-Detects when the integral literal or floating point (decimal or hexadecimal)
-literal has a non-uppercase suffix and provides a fix-it-hint
-with the uppercase suffix.
-
-All valid combinations of suffixes are supported.
-
-.. code:: c
-
-  auto x = 1;  // OK, no suffix.
-
-  auto x = 1u; // warning: integer literal suffix 'u' is not upper-case
-
-  auto x = 1U; // OK, suffix is uppercase.
-
-  ...
-
-Optionally, a list of the destination suffixes can be provided.
-When the suffix is found, a case-insensitive lookup in that list is made,
-and if a replacement is found that is different from the current suffix,
-then the diagnostic is issued. This allows for fine-grained control of
-what suffixes to consider and what their replacements should be.
-
-For example, given a list ``L;uL``:
-* ``l`` -> ``L``
-* ``L`` will be kept as is.
-* ``ul`` -> ``uL``
-* ``Ul`` -> ``uL``
-* ``UL`` -> ``uL``
-* ``uL`` will be kept as is.
-* ``ull`` will be kept as is, since it is not in the list
-* and so on.