summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPavel Labath <pavel@labath.sk>2018-12-28 13:34:50 +0000
committerPavel Labath <pavel@labath.sk>2018-12-28 13:34:50 +0000
commitf9cb776cfa71166edeff7b777694fd518611deda (patch)
tree3c36d5c8a8c22198ac6ccfe3f62c2fd9058d6e89
parent40f0461a61508aba60b6b0f3384b496c8fd33e0d (diff)
Fix signed-unsigned comparisons in MinidumpParserTest
-rw-r--r--lldb/unittests/Process/minidump/MinidumpParserTest.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/lldb/unittests/Process/minidump/MinidumpParserTest.cpp b/lldb/unittests/Process/minidump/MinidumpParserTest.cpp
index 610d3df8ef0..92ea20f7286 100644
--- a/lldb/unittests/Process/minidump/MinidumpParserTest.cpp
+++ b/lldb/unittests/Process/minidump/MinidumpParserTest.cpp
@@ -636,8 +636,8 @@ TEST_F(MinidumpParserTest, MinidumpDuplicateModuleMinAddress) {
// one time, we pick the one with the lowest base_of_image.
std::vector<const MinidumpModule *> filtered_modules =
parser->GetFilteredModuleList();
- EXPECT_EQ(1, filtered_modules.size());
- EXPECT_EQ(0x0000000000001000, filtered_modules[0]->base_of_image);
+ EXPECT_EQ(1u, filtered_modules.size());
+ EXPECT_EQ(0x0000000000001000u, filtered_modules[0]->base_of_image);
}
TEST_F(MinidumpParserTest, MinidumpModuleOrder) {
@@ -652,12 +652,12 @@ TEST_F(MinidumpParserTest, MinidumpModuleOrder) {
std::vector<const MinidumpModule *> filtered_modules =
parser->GetFilteredModuleList();
llvm::Optional<std::string> name;
- EXPECT_EQ(2, filtered_modules.size());
- EXPECT_EQ(0x0000000000002000, filtered_modules[0]->base_of_image);
+ EXPECT_EQ(2u, filtered_modules.size());
+ EXPECT_EQ(0x0000000000002000u, filtered_modules[0]->base_of_image);
name = parser->GetMinidumpString(filtered_modules[0]->module_name_rva);
ASSERT_TRUE((bool)name);
EXPECT_EQ(std::string("/tmp/a"), *name);
- EXPECT_EQ(0x0000000000001000, filtered_modules[1]->base_of_image);
+ EXPECT_EQ(0x0000000000001000u, filtered_modules[1]->base_of_image);
name = parser->GetMinidumpString(filtered_modules[1]->module_name_rva);
ASSERT_TRUE((bool)name);
EXPECT_EQ(std::string("/tmp/b"), *name);