diff options
| author | Jonathan Wakely <jwakely@redhat.com> | 2022-07-01 11:40:29 +0100 |
|---|---|---|
| committer | Jonathan Wakely <jwakely@redhat.com> | 2022-08-03 12:32:13 +0100 |
| commit | cff25d209b3e0f085fe69869617c50048de87e75 (patch) | |
| tree | 9ec5b1ad0b140402dfdc3ecb09095bd7ad1c965f /libstdc++-v3/testsuite/27_io/filesystem/operations/temp_directory_path.cc | |
| parent | e562236851e06091256593aa0d3fbda60a28e45b (diff) | |
libstdc++: Add nodiscard attribute to filesystem operations
Some of these are not truly "pure" because they access the file system,
e.g. exists and file_size, but they do not modify anything and are only
useful for the return value.
If you really want to use one of those functions just to check whether
an error is reported (either via an exception or an error_code&
argument) you can still do so, but you need to cast the discarded result
to void. Several tests need such a change, because they were indeed
only calling the functions to check for expected errors.
libstdc++-v3/ChangeLog:
* include/bits/fs_ops.h: Add nodiscard to all pure functions.
* include/experimental/bits/fs_ops.h: Likewise.
* testsuite/27_io/filesystem/operations/all.cc: Do not discard
results of absolute and canonical.
* testsuite/27_io/filesystem/operations/absolute.cc: Cast
discarded result to void.
* testsuite/27_io/filesystem/operations/canonical.cc: Likewise.
* testsuite/27_io/filesystem/operations/exists.cc: Likewise.
* testsuite/27_io/filesystem/operations/is_empty.cc: Likewise.
* testsuite/27_io/filesystem/operations/read_symlink.cc:
Likewise.
* testsuite/27_io/filesystem/operations/status.cc: Likewise.
* testsuite/27_io/filesystem/operations/symlink_status.cc:
Likewise.
* testsuite/27_io/filesystem/operations/temp_directory_path.cc:
Likewise.
* testsuite/experimental/filesystem/operations/canonical.cc:
Likewise.
* testsuite/experimental/filesystem/operations/exists.cc:
Likewise.
* testsuite/experimental/filesystem/operations/is_empty.cc:
Likewise.
* testsuite/experimental/filesystem/operations/read_symlink.cc:
Likewise.
* testsuite/experimental/filesystem/operations/temp_directory_path.cc:
Likewise.
(cherry picked from commit f7a148304a71f3d3ad6845b7966fdc3af88c9e45)
Diffstat (limited to 'libstdc++-v3/testsuite/27_io/filesystem/operations/temp_directory_path.cc')
| -rw-r--r-- | libstdc++-v3/testsuite/27_io/filesystem/operations/temp_directory_path.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libstdc++-v3/testsuite/27_io/filesystem/operations/temp_directory_path.cc b/libstdc++-v3/testsuite/27_io/filesystem/operations/temp_directory_path.cc index b4ef77f05e4..9dd52112330 100644 --- a/libstdc++-v3/testsuite/27_io/filesystem/operations/temp_directory_path.cc +++ b/libstdc++-v3/testsuite/27_io/filesystem/operations/temp_directory_path.cc @@ -117,7 +117,7 @@ test03() std::error_code ec2; try { - fs::temp_directory_path(); + (void) fs::temp_directory_path(); } catch (const fs::filesystem_error& e) { ec2 = e.code(); } @@ -141,7 +141,7 @@ test04() std::error_code ec2; try { - fs::temp_directory_path(); + (void) fs::temp_directory_path(); } catch (const fs::filesystem_error& e) { ec2 = e.code(); } |