diff options
| author | Nikhil Benesch <nikhil.benesch@gmail.com> | 2020-10-26 18:42:08 +0000 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2020-10-28 18:20:50 -0700 |
| commit | 0cdde1e7ae197366e17e5ef50bf68d4d5760df01 (patch) | |
| tree | 35bfb1e6e1551c39558abb3b699b032e952823c4 /libgo/sysinfo.c | |
| parent | e93aae4a497c38b46df818a629c78149fe6af24b (diff) | |
libgo: handle linking to NetBSD's versioned symbols
On NetBSD, for backwards compatibility, various libc symbols are
renamed to a symbol with a version suffix. For example, this is the
(abbreviated) definition of sigaction:
int sigaction(...) __asm__ ("__sigaction14")
This poses a challenge for libgo, which attempts to link sigaction by
way of an "//extern" comment:
//extern sigaction
func sigaction(...)
This results in a reference to the deprecated compatibility symbol
"sigaction", rather than the desired "__sigaction14" symbol.
This patch introduces a new "//extern-sysinfo" comment to handle this
situation. The new mklinknames.awk script scans a package for these
comments and outputs a "//go:linkname" directive that links the wrapper
to the correct versioned symbol, as determined by parsing the __asm__
annotation on the function's declaration in gen-sysinfo.go.
For now, only the following packages are scanned by mklinknames.awk:
os
os/user
runtime
syscall
gotools/:
* Makefile.am (check-runtime): Add runtime_linknames.go to
--extrafiles.
* Makefile.in: Regenerate.
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/265125
Diffstat (limited to 'libgo/sysinfo.c')
| -rw-r--r-- | libgo/sysinfo.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/libgo/sysinfo.c b/libgo/sysinfo.c index ba84071a7bb..7086381a14c 100644 --- a/libgo/sysinfo.c +++ b/libgo/sysinfo.c @@ -10,6 +10,7 @@ #include "config.h" #include <stddef.h> +#include <stdlib.h> #include <sys/types.h> #include <dirent.h> #include <errno.h> @@ -177,6 +178,9 @@ #if defined(HAVE_PORT_H) #include <port.h> #endif +#if defined(HAVE_LWP_H) +#include <lwp.h> +#endif #ifdef USE_LIBFFI #include "ffi.h" |