summaryrefslogtreecommitdiff
path: root/contrib/gcc-changelog
diff options
context:
space:
mode:
authorMartin Liska <mliska@suse.cz>2020-06-10 09:57:51 +0200
committerMartin Liska <mliska@suse.cz>2020-06-10 09:58:07 +0200
commit771e60dd073b4dc0663fa9282b854dafdd92242d (patch)
tree66c0ed26c06a563c9d33214217fbe48852e441e6 /contrib/gcc-changelog
parent1ea9a0b74e60e6cdca6372403d7bd564a5410d82 (diff)
gcc-changelog: add more Review by prefixes.
contrib/ChangeLog: * gcc-changelog/git_commit.py: Add more supported prefixes. * gcc-changelog/test_email.py: Fix one flake8 error. * gcc-changelog/test_patches.txt: Add tested for newly supported prefixes.
Diffstat (limited to 'contrib/gcc-changelog')
-rwxr-xr-xcontrib/gcc-changelog/git_commit.py8
-rwxr-xr-xcontrib/gcc-changelog/test_email.py5
-rw-r--r--contrib/gcc-changelog/test_patches.txt4
3 files changed, 10 insertions, 7 deletions
diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index 0b350ba7fda..eac64887053 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -159,12 +159,10 @@ LINE_LIMIT = 100
TAB_WIDTH = 8
CO_AUTHORED_BY_PREFIX = 'co-authored-by: '
CHERRY_PICK_PREFIX = '(cherry picked from commit '
-REVIEWED_BY_PREFIX = 'reviewed-by: '
-REVIEWED_ON_PREFIX = 'reviewed-on: '
-SIGNED_OFF_BY_PREFIX = 'signed-off-by: '
-REVIEW_PREFIXES = (REVIEWED_BY_PREFIX, REVIEWED_ON_PREFIX,
- SIGNED_OFF_BY_PREFIX)
+REVIEW_PREFIXES = ('reviewed-by: ', 'reviewed-on: ', 'signed-off-by: ',
+ 'acked-by: ', 'tested-by: ', 'reported-by: ',
+ 'suggested-by: ')
class Error:
diff --git a/contrib/gcc-changelog/test_email.py b/contrib/gcc-changelog/test_email.py
index df57bb5c94a..c50687bc331 100755
--- a/contrib/gcc-changelog/test_email.py
+++ b/contrib/gcc-changelog/test_email.py
@@ -161,8 +161,9 @@ class TestGccChangelog(unittest.TestCase):
def test_additional_author_list(self):
email = self.from_patch_glob('0342')
- assert (email.errors[1].message == 'additional author must be indented '
- 'with one tab and four spaces')
+ msg = 'additional author must be indented ' \
+ 'with one tab and four spaces'
+ assert email.errors[1].message == msg
def test_trailing_whitespaces(self):
email = self.get_git_email('trailing-whitespaces.patch')
diff --git a/contrib/gcc-changelog/test_patches.txt b/contrib/gcc-changelog/test_patches.txt
index 15fe0df1ccc..1dec932f783 100644
--- a/contrib/gcc-changelog/test_patches.txt
+++ b/contrib/gcc-changelog/test_patches.txt
@@ -2430,6 +2430,10 @@ Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Reviewed-on: Keith Packard <keithp@keithp.com>
Co-Authored-by: Keith Packard <keithp@keithp.com>
+Acked-By: Keith Packard <keithp@keithp.com>
+Tested-by: Keith Packard <keithp@keithp.com>
+Reported-by: Keith Packard <keithp@keithp.com>
+Suggested-by: Keith Packard <keithp@keithp.com>
---
gcc/ChangeLog | 5 +++++
gcc/config/riscv/riscv.c | 40 ++++++++++++++++++++++++++++++++++++++++