diff options
| author | Maciej W. Rozycki <macro@mips.com> | 2018-07-20 13:21:33 +0100 |
|---|---|---|
| committer | Maciej W. Rozycki <macro@mips.com> | 2018-07-20 13:21:33 +0100 |
| commit | db841b6fcd8b3bc2e6d6774e81c14dfbb9ac815d (patch) | |
| tree | 5dc8f055e8d4a0d2ce9ef102046f01802c632bec /bfd/elfxx-mips.c | |
| parent | 0458ca44409420c3d5cdbbb21561ee71fd930d31 (diff) | |
MIPS/LD: Fix crashing with a discarded dynamic relocation section
Fix a crash that occurs in `_bfd_mips_elf_finish_dynamic_sections' if a
dynamic relocation section has been created, but marked to be discarded
by an assignment to the /DISCARD/ output section in a linker script.
In that case the output section is the absolute section, which has no
ELF section data attached, so trying to set its `sh_size' parameter
causes a null pointer dereference.
This is only done as the value for the DT_RELSZ dynamic entry is being
set, so fix the problem by not creating DT_REL, DT_RELSZ or DT_RELENT
dynamic entries in the first place if the dynamic relocation section
will not be output, as with no dynamic relocation data present these
would not serve their purpose anyway.
Add a generic ELF test case to verify that no dynamic relocation data is
reported in the dynamic segment.
bfd/
* elfxx-mips.c (_bfd_mips_elf_size_dynamic_sections): Do not
create DT_REL, DT_RELSZ or DT_RELENT dynamic entries if the
dynamic relocation section will be discarded from output.
(_bfd_mips_elf_finish_dynamic_sections) <DT_RELSZ>: Assert that
the dynamic relocation section will be retained in output.
ld/
* testsuite/ld-elf/reloc-discard.d: New test.
* testsuite/ld-elf/reloc-discard.ld: New test linker script.
* testsuite/ld-elf/reloc-discard.s: New test source.
Diffstat (limited to 'bfd/elfxx-mips.c')
| -rw-r--r-- | bfd/elfxx-mips.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c index d91942301c..cc767ea6bf 100644 --- a/bfd/elfxx-mips.c +++ b/bfd/elfxx-mips.c @@ -9890,7 +9890,8 @@ _bfd_mips_elf_size_dynamic_sections (bfd *output_bfd, } else { - if (sreldyn && sreldyn->size > 0) + if (sreldyn && sreldyn->size > 0 + && !bfd_is_abs_section (sreldyn->output_section)) { if (! MIPS_ELF_ADD_DYNAMIC_ENTRY (info, DT_REL, 0)) return FALSE; @@ -11798,6 +11799,7 @@ _bfd_mips_elf_finish_dynamic_sections (bfd *output_bfd, : sizeof (Elf32_External_Rel))); /* Adjust the section size too. Tools like the prelinker can reasonably expect the values to the same. */ + BFD_ASSERT (!bfd_is_abs_section (s->output_section)); elf_section_data (s->output_section)->this_hdr.sh_size = dyn.d_un.d_val; break; |