blob: f0d20a00a4ae16203c1285a8839d89d60169acfb (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
|
[TCWG-CI] Failure after glibc commit: glibc-2.37.9000-512-gabcf8db7fa resolv_conf: release lock on allocation failure (bug 30527)
In CI config tcwg_glibc_check/master-arm after:
| commit abcf8db7fa46b73fd5b8193ce11f9312301b84c7
| Author: Andreas Schwab <schwab@suse.de>
| Date: Wed Jun 7 11:21:48 2023 +0200
|
| resolv_conf: release lock on allocation failure (bug 30527)
|
| When the initial allocation of global fails, the local lock is left
| locked.
|
| Reported by Steffen Lammel of SAP HANA development.
Results changed to
-10
# init_abe_sysroot:
-3
# build_abe glibc -- --disable install:
-2
# build_abe dejagnu:
-1
# build_abe check_glibc --check_patch linaro-local/dejagnu-sum -- --disable install:
0
# === glibc tests ===
#
# Running glibc:malloc ...
# FAIL: malloc/tst-malloc-tcache-leak-malloc-check
# FAIL: malloc/tst-malloc-tcache-leak-malloc-hugetlb1
# FAIL: malloc/tst-malloc-tcache-leak-malloc-hugetlb2
# FAIL: malloc/tst-mallocfork2-malloc-check
# FAIL: malloc/tst-mallocfork2-malloc-hugetlb1
# FAIL: malloc/tst-mallocfork2-malloc-hugetlb2
# FAIL: malloc/tst-mallocfork3-malloc-check
# FAIL: malloc/tst-mallocfork3-malloc-hugetlb1
# FAIL: malloc/tst-mallocfork3-malloc-hugetlb2
#
# === Results Summary ===
# regressed
From
-10
# init_abe_sysroot:
-3
# build_abe glibc -- --disable install:
-2
# build_abe dejagnu:
-1
# build_abe check_glibc --check_patch linaro-local/dejagnu-sum -- --disable install:
0
-----------------8<--------------------------8<--------------------------8<--------------------------
THIS IS THE END OF SHORT SUMMARY. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
Current build : https://ci.linaro.org/job/tcwg_glibc_check--master-arm-build/298/artifact/artifacts
Reference build : https://ci.linaro.org/job/tcwg_glibc_check--master-arm-build/292/artifact/artifacts
Reproduce last good and first bad builds:
-----------------8<--------------------------8<--------------------------8<--------------------------
mkdir -p investigate-glibc-abcf8db7fa46b73fd5b8193ce11f9312301b84c7
cd investigate-glibc-abcf8db7fa46b73fd5b8193ce11f9312301b84c7
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests for bad and good builds
mkdir -p bad/artifacts good/artifacts
curl -o bad/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_glibc_check--master-arm-build/298/artifact/artifacts/manifest.sh --fail
curl -o good/artifacts/manifest.sh https://ci.linaro.org/job/tcwg_glibc_check--master-arm-build/292/artifact/artifacts/manifest.sh --fail
# Reproduce bad build
(cd bad; ../jenkins-scripts/tcwg_glibc_check-build.sh ^^ true %%rr[top_artifacts] artifacts)
# Reproduce good build
(cd good; ../jenkins-scripts/tcwg_glibc_check-build.sh ^^ true %%rr[top_artifacts] artifacts)
---------------->8-------------------------->8-------------------------->8---------------------------
For latest status see comments in https://linaro.atlassian.net/browse/GNU-692
Info generated by the CI regarding this commit:
Status of glibc-2.37.9000-512-gabcf8db7fa commit for tcwg_glibc_check:
commit abcf8db7fa46b73fd5b8193ce11f9312301b84c7
Author: Andreas Schwab <schwab@suse.de>
resolv_conf: release lock on allocation failure (bug 30527)
* master-arm
** Failure
** https://ci.linaro.org/job/tcwg_glibc_check--master-arm-build/298/
Full commit (up to 100 lines):
<cut>
commit abcf8db7fa46b73fd5b8193ce11f9312301b84c7
Author: Andreas Schwab <schwab@suse.de>
Date: Wed Jun 7 11:21:48 2023 +0200
resolv_conf: release lock on allocation failure (bug 30527)
When the initial allocation of global fails, the local lock is left
locked.
Reported by Steffen Lammel of SAP HANA development.
diff --git a/resolv/resolv_conf.c b/resolv/resolv_conf.c
index bd5890773b..8bc9edc634 100644
--- a/resolv/resolv_conf.c
+++ b/resolv/resolv_conf.c
@@ -93,7 +93,10 @@ get_locked_global (void)
{
global_copy = calloc (1, sizeof (*global));
if (global_copy == NULL)
- return NULL;
+ {
+ __libc_lock_unlock (lock);
+ return NULL;
+ }
atomic_store_relaxed (&global, global_copy);
resolv_conf_array_init (&global_copy->array);
}
</cut>
|
