summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorTomas Melin <tomas.melin@vaisala.com>2022-04-07 19:16:59 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-04-27 13:15:30 +0200
commit326f058816c4b56d17e12ca4630f6cad718ca842 (patch)
treef66f70a5f3a7ac0a84c62ffa82f1605a96f36f9f /arch
parentf7fe17fa90e4d1c743fb0e6e6af2bd8b0a4a4a34 (diff)
net: macb: Restart tx only if queue pointer is lagging
[ Upstream commit 5ad7f18cd82cee8e773d40cc7a1465a526f2615c ] commit 4298388574da ("net: macb: restart tx after tx used bit read") added support for restarting transmission. Restarting tx does not work in case controller asserts TXUBR interrupt and TQBP is already at the end of the tx queue. In that situation, restarting tx will immediately cause assertion of another TXUBR interrupt. The driver will end up in an infinite interrupt loop which it cannot break out of. For cases where TQBP is at the end of the tx queue, instead only clear TX_USED interrupt. As more data gets pushed to the queue, transmission will resume. This issue was observed on a Xilinx Zynq-7000 based board. During stress test of the network interface, driver would get stuck on interrupt loop within seconds or minutes causing CPU to stall. Signed-off-by: Tomas Melin <tomas.melin@vaisala.com> Tested-by: Claudiu Beznea <claudiu.beznea@microchip.com> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> Link: https://lore.kernel.org/r/20220407161659.14532-1-tomas.melin@vaisala.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions