diff options
| author | Li Wang <liwang@redhat.com> | 2019-04-04 11:09:19 +0800 |
|---|---|---|
| committer | Cyril Hrubis <chrubis@suse.cz> | 2019-04-04 12:38:31 +0200 |
| commit | 969e6f3e5ebe541d343568fac52beff9a839e275 (patch) | |
| tree | 92e909f67c16869a910e99cc6f7a39e8d64ea7b7 /testcases/kernel | |
| parent | 1f9b90507552646334d7590d13137b2c0ed40c9d (diff) | |
hugeshmat04: fix long integer overflow on 32bit system
To fix an obvious integer overflow when system(32bit) original nr_hugepages >= 512.
--- Error log ---
# grep -i hugepage /proc/meminfo
HugePages_Total: 512
HugePages_Free: 512
HugePages_Rsvd: 0
HugePages_Surp: 0
Hugepagesize: 2048 kB
# readelf -h hugeshmat04 |grep -i ELF
ELF Header:
Class: ELF32
# ./hugeshmat04
tst_test.c:1085: INFO: Timeout per run is 0h 05m 00s
mem.c:814: INFO: set nr_hugepages to -1024
mem.c:823: BROK: nr_hugepages = 512, but expect -1024
mem.c:814: INFO: set nr_hugepages to 512
-----------------
Reported-by: Zhonghua Hao <zhao@redhat.com>
Signed-off-by: Li Wang <liwang@redhat.com>
Acked-by: Cyril Hrubis <chrubis@suse.cz>
Diffstat (limited to 'testcases/kernel')
| -rw-r--r-- | testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat04.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat04.c b/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat04.c index b4dea53d1..d375810cb 100644 --- a/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat04.c +++ b/testcases/kernel/mem/hugetlb/hugeshmat/hugeshmat04.c @@ -99,7 +99,7 @@ static void setup(void) hpage_size = SAFE_READ_MEMINFO("Hugepagesize:") * 1024; - hugepages = (orig_hugepages * hpage_size + SIZE) / hpage_size; + hugepages = orig_hugepages + SIZE / hpage_size; set_sys_tune("nr_hugepages", hugepages, 1); } |