diff options
author | Cyril Hrubis <chrubis@suse.cz> | 2019-04-30 15:23:12 +0200 |
---|---|---|
committer | Cyril Hrubis <chrubis@suse.cz> | 2019-04-30 16:08:57 +0200 |
commit | c4621156a497d04088bcfb7aaa8f2b9793f98dab (patch) | |
tree | 59b0fa742f6f42e9e44737f1ac9a1c9f2cab1c23 /include | |
parent | 3b243cdec3a71dbb08f92d525f580f8064b56f69 (diff) |
testcases.mk: Fix libs/ path for out-of-tree build
The path to the Makefile was not correct for the out-of-tree build
because it was pointing to the build directory rather than to the source
directory.
Apparently this also caused random failures for out-of-tree build. For
some reason when building syscalls/set_mempolicy/ testcases the rebuild
of the libltpnuma.a library is triggered for out-of-tree build for about
10% of the cases on massively parallel build. Which as far as I can tell
shouldn't happen since we build everything in the libs/ directory as a
prerequisite of the testcases/ directory. So there is likely some
strange race condition happening and while this does not fix the actual
race it makes it quite harmless since the target was already build and
the make in the libs/libltpnuma/ directory will be no-op.
Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
Acked-by: Jan Stancek <jstancek@redhat.com>
Tested-by: Petr Vorel <pvorel@suse.cz>
Diffstat (limited to 'include')
-rw-r--r-- | include/mk/testcases.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/mk/testcases.mk b/include/mk/testcases.mk index 131854ec7..684655fbf 100644 --- a/include/mk/testcases.mk +++ b/include/mk/testcases.mk @@ -49,7 +49,7 @@ LTPLIBS_FILES = $(addsuffix .a, $(addprefix $(abs_top_builddir)/libs/, $(foreach MAKE_DEPS += $(LTPLIBS_FILES) $(LTPLIBS_FILES): $(LTPLIBS_DIRS) - $(MAKE) -C "$^" -f "$^/Makefile" all + $(MAKE) -C "$^" -f "$(subst $(abs_top_builddir),$(abs_top_srcdir),$^)/Makefile" all LDFLAGS += $(addprefix -L$(top_builddir)/libs/lib, $(LTPLIBS)) |